From: Brian Norris <briannorris@chromium.org>
To: Jeffy Chen <jeffy.chen@rock-chips.com>
Cc: linux-wireless@vger.kernel.org, akarwar@marvell.com,
Xinming Hu <huxm@marvell.com>, Kalle Valo <kvalo@codeaurora.org>,
Ganapathi Bhat <gbhat@marvell.com>,
Amitkumar Karwar <amitkarwar@gmail.com>,
linux-kernel@vger.kernel.org,
Nishant Sarmukadam <nishants@marvell.com>,
netdev@vger.kernel.org
Subject: Re: [PATCH v2] mwifiex: uninit wakeup info in the error handling
Date: Thu, 6 Jul 2017 10:15:58 -0700 [thread overview]
Message-ID: <20170706171557.GA121983@google.com> (raw)
In-Reply-To: <1499327728-25388-1-git-send-email-jeffy.chen@rock-chips.com>
On Thu, Jul 06, 2017 at 03:55:28PM +0800, Jeffy Chen wrote:
> We inited wakeup info at the beginning of mwifiex_add_card, so we need
> to uninit it in the error handling.
>
> It's much the same as what we did in:
> 36908c4 mwifiex: uninit wakeup info when removing device
>
> Signed-off-by: Jeffy Chen <jeffy.chen@rock-chips.com>
>
> ---
>
> Changes in v2:
> Uninit wakeup when _mwifiex_fw_dpc failed too.
Looks good to me:
Reviewed-by: Brian Norris <briannorris@chromium.org>
next prev parent reply other threads:[~2017-07-06 17:15 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-07-06 7:55 [PATCH v2] mwifiex: uninit wakeup info in the error handling Jeffy Chen
2017-07-06 17:15 ` Brian Norris [this message]
2017-07-28 14:50 ` [v2] " Kalle Valo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170706171557.GA121983@google.com \
--to=briannorris@chromium.org \
--cc=akarwar@marvell.com \
--cc=amitkarwar@gmail.com \
--cc=gbhat@marvell.com \
--cc=huxm@marvell.com \
--cc=jeffy.chen@rock-chips.com \
--cc=kvalo@codeaurora.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=nishants@marvell.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).