* [PATCH net] nfp: flower: add missing clean up call to avoid memory leaks
@ 2017-07-07 0:29 Jakub Kicinski
2017-07-07 8:17 ` David Miller
0 siblings, 1 reply; 2+ messages in thread
From: Jakub Kicinski @ 2017-07-07 0:29 UTC (permalink / raw)
To: netdev; +Cc: simon.horman, oss-drivers, Jakub Kicinski
nfp_flower_metadata_cleanup() is defined but never invoked,
not calling it will cause us to leak mask and statistics
queue memory on the host.
Fixes: 43f84b72c50d ("nfp: add metadata to each flow offload")
Signed-off-by: Jakub Kicinski <jakub.kicinski@netronome.com>
---
drivers/net/ethernet/netronome/nfp/flower/main.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/net/ethernet/netronome/nfp/flower/main.c b/drivers/net/ethernet/netronome/nfp/flower/main.c
index fc10f27e0a0c..6a65c8b33807 100644
--- a/drivers/net/ethernet/netronome/nfp/flower/main.c
+++ b/drivers/net/ethernet/netronome/nfp/flower/main.c
@@ -356,6 +356,7 @@ static int nfp_flower_init(struct nfp_app *app)
static void nfp_flower_clean(struct nfp_app *app)
{
+ nfp_flower_metadata_cleanup(app);
vfree(app->priv);
app->priv = NULL;
}
--
2.11.0
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH net] nfp: flower: add missing clean up call to avoid memory leaks
2017-07-07 0:29 [PATCH net] nfp: flower: add missing clean up call to avoid memory leaks Jakub Kicinski
@ 2017-07-07 8:17 ` David Miller
0 siblings, 0 replies; 2+ messages in thread
From: David Miller @ 2017-07-07 8:17 UTC (permalink / raw)
To: jakub.kicinski; +Cc: netdev, simon.horman, oss-drivers
From: Jakub Kicinski <jakub.kicinski@netronome.com>
Date: Thu, 6 Jul 2017 17:29:05 -0700
> nfp_flower_metadata_cleanup() is defined but never invoked,
> not calling it will cause us to leak mask and statistics
> queue memory on the host.
>
> Fixes: 43f84b72c50d ("nfp: add metadata to each flow offload")
> Signed-off-by: Jakub Kicinski <jakub.kicinski@netronome.com>
Applied.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2017-07-07 8:18 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2017-07-07 0:29 [PATCH net] nfp: flower: add missing clean up call to avoid memory leaks Jakub Kicinski
2017-07-07 8:17 ` David Miller
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).