From: David Miller <davem@davemloft.net>
To: garsilva@embeddedor.com
Cc: andrew@lunn.ch, nbd@openwrt.org, blogic@openwrt.org,
matthias.bgg@gmail.com, netdev@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-mediatek@lists.infradead.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] net: ethernet: mediatek: remove useless code in mtk_probe()
Date: Sat, 08 Jul 2017 11:28:19 +0100 (WEST) [thread overview]
Message-ID: <20170708.112819.2140475148838704261.davem@davemloft.net> (raw)
In-Reply-To: <20170707202333.GA5114@embeddedgus>
From: "Gustavo A. R. Silva" <garsilva@embeddedor.com>
Date: Fri, 7 Jul 2017 15:23:34 -0500
> Remove useless local variables _match_, _soc_ and the code related.
>
> Notice that
>
> const struct of_device_id of_mtk_match[] = {
> { .compatible = "mediatek,mt2701-eth" },
> {},
> };
>
> So match->data is NULL.
>
> Suggested-by: Andrew Lunn <andrew@lunn.ch>
> Signed-off-by: Gustavo A. R. Silva <garsilva@embeddedor.com>
Applied, thanks.
If someone needs this they can it back, in a less buggy form.
prev parent reply other threads:[~2017-07-08 10:28 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-07-07 7:11 [PATCH] net: ethernet: mediatek: add NULL check on of_match_device() return value Gustavo A. R. Silva
2017-07-07 14:51 ` Matthias Brugger
2017-07-07 14:57 ` Andrew Lunn
2017-07-07 20:08 ` Gustavo A. R. Silva
2017-07-07 20:23 ` [PATCH] net: ethernet: mediatek: remove useless code in mtk_probe() Gustavo A. R. Silva
2017-07-08 6:56 ` Sean Wang
2017-07-08 10:28 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170708.112819.2140475148838704261.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=andrew@lunn.ch \
--cc=blogic@openwrt.org \
--cc=garsilva@embeddedor.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=matthias.bgg@gmail.com \
--cc=nbd@openwrt.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).