From: Marc Duponcheel <marc@offline.be>
To: netdev@vger.kernel.org
Cc: Marc Duponcheel <marc@offline.be>
Subject: Re: meson-gxbb-p200 4.12.0 network TCP transfer stalls
Date: Tue, 11 Jul 2017 01:48:45 +0200 [thread overview]
Message-ID: <20170710234845.GA24423@offline.be> (raw)
In-Reply-To: <20170708005542.GA20515@offline.be>
FYI
I changed 4.12.0 drivers/net/phy/realtek.c RTL8211F code to equal the
3.14.29 amlogic/ethernet/phy/am_realtek.c code and now the networking
works without TCP stalls.
I don't say below patch should be considered mainstream (as maybe some
4.12.0 rtl8211f_config_init code should not be removed) but sure
someone could figure out what best patch is...
--
# diff -U2 realtek.c.orig realtek.c
--- realtek.c.orig 2017-07-03 01:07:02.000000000 +0200
+++ realtek.c 2017-07-11 01:32:20.273445023 +0200
@@ -94,28 +94,27 @@
}
+#define RTL8211F_MMD_CTRL 0x0D
+#define RTL8211F_MMD_DATA 0x0E
+#define RTL8211E_INER_LINK_STAT 0x10
+
static int rtl8211f_config_init(struct phy_device *phydev)
{
- int ret;
- u16 reg;
-
- ret = genphy_config_init(phydev);
- if (ret < 0)
- return ret;
-
- phy_write(phydev, RTL8211F_PAGE_SELECT, 0xd08);
- reg = phy_read(phydev, 0x11);
-
- /* enable TX-delay for rgmii-id and rgmii-txid, otherwise disable it */
- if (phydev->interface == PHY_INTERFACE_MODE_RGMII_ID ||
- phydev->interface == PHY_INTERFACE_MODE_RGMII_TXID)
- reg |= RTL8211F_TX_DELAY;
- else
- reg &= ~RTL8211F_TX_DELAY;
-
- phy_write(phydev, 0x11, reg);
- /* restore to default page 0 */
- phy_write(phydev, RTL8211F_PAGE_SELECT, 0x0);
-
+ int val;
+/* we want to disable eee */
+ phy_write(phydev, RTL8211F_MMD_CTRL, 0x7);
+ phy_write(phydev, RTL8211F_MMD_DATA, 0x3c);
+ phy_write(phydev, RTL8211F_MMD_CTRL, 0x4007);
+ phy_write(phydev, RTL8211F_MMD_DATA, 0x0);
+/* disable 1000m adv*/
+ val = phy_read(phydev, 0x9);
+ phy_write(phydev, 0x9, val&(~(1<<9)));
+/* rx reg 21 bit 3 tx reg 17 bit 8 */
+/*
+ phy_write(phydev, 0x1f, 0xd08);
+ val = phy_read(phydev, 0x15);
+ phy_write(phydev, 0x15,val| 1<<21);
+ */
return 0;
+/* Enable Auto Power Saving mode */
}
@@ -167,6 +166,6 @@
.name = "RTL8211F Gigabit Ethernet",
.phy_id_mask = 0x001fffff,
- .features = PHY_GBIT_FEATURES,
- .flags = PHY_HAS_INTERRUPT,
+ .features = PHY_GBIT_FEATURES | SUPPORTED_Pause | SUPPORTED_Asym_Pause,
+ .flags = PHY_HAS_INTERRUPT | PHY_HAS_MAGICANEG,
.config_aneg = &genphy_config_aneg,
--
On 2017 Jul 08, Marc Duponcheel wrote:
> Hi all
>
> Similar to 'crow'
>
> ARM GLX Khadas VIM Pro - Ethernet detected as only 10Mbps and stalled after some traffic
>
> I also have the situation where copying large file over LAN stalls.
>
> 3.14.29 performance is good 4.12.0 performance not
>
>
> Perhaps one must compare 3.14.29 am_realtek.c and realtek.c with 4.12.0 realtek.c
>
>
> thanks
have a nice day
next prev parent reply other threads:[~2017-07-10 23:41 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-07-08 0:55 meson-gxbb-p200 4.12.0 network TCP transfer stalls Marc Duponcheel
2017-07-10 23:48 ` Marc Duponcheel [this message]
2017-07-11 0:34 ` Marc Duponcheel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170710234845.GA24423@offline.be \
--to=marc@offline.be \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).