From: David Miller <davem@davemloft.net>
To: christophe.jaillet@wanadoo.fr
Cc: benve@cisco.com, govind@gmx.com, neepatel@cisco.com,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
kernel-janitors@vger.kernel.org
Subject: Re: [PATCH] cisco: enic: Fic an error handling path in 'vnic_dev_init_devcmd2()'
Date: Tue, 11 Jul 2017 10:54:32 -0700 (PDT) [thread overview]
Message-ID: <20170711.105432.2013597475678597815.davem@davemloft.net> (raw)
In-Reply-To: <20170708045135.14753-1-christophe.jaillet@wanadoo.fr>
From: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
Date: Sat, 8 Jul 2017 06:51:35 +0200
> if 'ioread32()' returns 0xFFFFFFF, we have to go through the error
> handling path as done everywhere else in this function.
>
> Move the 'err_free_wq' label to better match its name and its location
> and add a new label 'err_disable_wq'.
> Update the code accordingly.
>
> Fixes: 373fb0873d43 ("enic: add devcmd2")
> Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
Looks good, applied, thanks.
prev parent reply other threads:[~2017-07-11 17:54 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-07-08 4:51 [PATCH] cisco: enic: Fic an error handling path in 'vnic_dev_init_devcmd2()' Christophe JAILLET
2017-07-11 17:54 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170711.105432.2013597475678597815.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=benve@cisco.com \
--cc=christophe.jaillet@wanadoo.fr \
--cc=govind@gmx.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=neepatel@cisco.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).