From: David Miller <davem@davemloft.net>
To: Michal.Kalderon@cavium.com
Cc: netdev@vger.kernel.org, dan.carpenter@oracle.com, Yuval.Mintz@cavium.com
Subject: Re: [PATCH net] qed: Fix printk option passed when printing ipv6 addresses
Date: Tue, 11 Jul 2017 13:36:21 -0700 (PDT) [thread overview]
Message-ID: <20170711.133621.992406600321132485.davem@davemloft.net> (raw)
In-Reply-To: <1499594416-20850-1-git-send-email-Michal.Kalderon@cavium.com>
From: Michal Kalderon <Michal.Kalderon@cavium.com>
Date: Sun, 9 Jul 2017 13:00:16 +0300
> The option "h" (host order ) exists for ipv4 only.
> Remove the h when printing ipv6 addresses.
>
> Lead to the following smatch warning:
>
> drivers/net/ethernet/qlogic/qed/qed_iwarp.c:585 qed_iwarp_print_tcp_ramrod()
> warn: '%pI6' can only be followed by c
> drivers/net/ethernet/qlogic/qed/qed_iwarp.c:1521 qed_iwarp_print_cm_info()
> warn: '%pI6' can only be followed by c
>
> Fixes commit 456a584947d5 ("qed: iWARP CM add passive side connect")
>
> Reported-by: Dan Carpenter <dan.carpenter@oracle.com>
> Signed-off-by: Michal Kalderon <Michal.Kalderon@cavium.com>
> Signed-off-by: Yuval Mintz <Yuval.Mintz@cavium.com>
Applied.
prev parent reply other threads:[~2017-07-11 20:36 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-07-09 10:00 [PATCH net] qed: Fix printk option passed when printing ipv6 addresses Michal Kalderon
2017-07-11 20:36 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170711.133621.992406600321132485.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=Michal.Kalderon@cavium.com \
--cc=Yuval.Mintz@cavium.com \
--cc=dan.carpenter@oracle.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).