* [PATCH net] nfp: freeing the wrong variable
@ 2017-07-12 7:42 Dan Carpenter
2017-07-12 7:54 ` Jakub Kicinski
2017-07-12 15:19 ` David Miller
0 siblings, 2 replies; 3+ messages in thread
From: Dan Carpenter @ 2017-07-12 7:42 UTC (permalink / raw)
To: Jakub Kicinski, Pieter Jansen van Vuuren
Cc: David S. Miller, Simon Horman, oss-drivers, netdev,
kernel-janitors
We accidentally free a NULL pointer and leak the pointer we want to
free. Also you can tell from the label name what was intended. :)
Fixes: abfcdc1de9bf ("nfp: add a stats handler for flower offloads")
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
diff --git a/drivers/net/ethernet/netronome/nfp/flower/metadata.c b/drivers/net/ethernet/netronome/nfp/flower/metadata.c
index fec0ff2ca94f..3226ddc55f99 100644
--- a/drivers/net/ethernet/netronome/nfp/flower/metadata.c
+++ b/drivers/net/ethernet/netronome/nfp/flower/metadata.c
@@ -419,7 +419,7 @@ int nfp_flower_metadata_init(struct nfp_app *app)
return 0;
err_free_last_used:
- kfree(priv->stats_ids.free_list.buf);
+ kfree(priv->mask_ids.last_used);
err_free_mask_id:
kfree(priv->mask_ids.mask_id_free_list.buf);
return -ENOMEM;
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH net] nfp: freeing the wrong variable
2017-07-12 7:42 [PATCH net] nfp: freeing the wrong variable Dan Carpenter
@ 2017-07-12 7:54 ` Jakub Kicinski
2017-07-12 15:19 ` David Miller
1 sibling, 0 replies; 3+ messages in thread
From: Jakub Kicinski @ 2017-07-12 7:54 UTC (permalink / raw)
To: Dan Carpenter
Cc: Pieter Jansen van Vuuren, David S. Miller, Simon Horman,
oss-drivers, netdev, kernel-janitors
On Wed, 12 Jul 2017 10:42:06 +0300, Dan Carpenter wrote:
> We accidentally free a NULL pointer and leak the pointer we want to
> free. Also you can tell from the label name what was intended. :)
>
> Fixes: abfcdc1de9bf ("nfp: add a stats handler for flower offloads")
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Acked-by: Jakub Kicinski <jakub.kicinski@netronome.com>
Thanks!
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH net] nfp: freeing the wrong variable
2017-07-12 7:42 [PATCH net] nfp: freeing the wrong variable Dan Carpenter
2017-07-12 7:54 ` Jakub Kicinski
@ 2017-07-12 15:19 ` David Miller
1 sibling, 0 replies; 3+ messages in thread
From: David Miller @ 2017-07-12 15:19 UTC (permalink / raw)
To: dan.carpenter
Cc: jakub.kicinski, pieter.jansenvanvuuren, simon.horman, oss-drivers,
netdev, kernel-janitors
From: Dan Carpenter <dan.carpenter@oracle.com>
Date: Wed, 12 Jul 2017 10:42:06 +0300
> We accidentally free a NULL pointer and leak the pointer we want to
> free. Also you can tell from the label name what was intended. :)
>
> Fixes: abfcdc1de9bf ("nfp: add a stats handler for flower offloads")
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Applied.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2017-07-12 15:19 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2017-07-12 7:42 [PATCH net] nfp: freeing the wrong variable Dan Carpenter
2017-07-12 7:54 ` Jakub Kicinski
2017-07-12 15:19 ` David Miller
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).