From: David Miller <davem@davemloft.net>
To: tsbogend@alpha.franken.de
Cc: isubramanian@apm.com, kchudgar@apm.com, qnguyen@apm.com,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH net] xgene: Don't fail probe, if there is no clk resource for SGMII interfaces
Date: Thu, 13 Jul 2017 09:22:15 -0700 (PDT) [thread overview]
Message-ID: <20170713.092215.720040460171963059.davem@davemloft.net> (raw)
In-Reply-To: <20170713092144.31751508094@solo.franken.de>
From: Thomas Bogendoerfer <tsbogend@alpha.franken.de>
Date: Thu, 13 Jul 2017 10:57:40 +0200
> From: Thomas Bogendoerfer <tbogendoerfer@suse.de>
>
> This change fixes following problem
>
> [ 1.827940] xgene-enet: probe of 1f210030.ethernet failed with error -2
>
> which leads to a missing ethernet interface (reproducable at least on
> Gigabyte MP30-AR0 and APM Mustang systems).
>
> The check for a valid clk resource fails, because DT doesn't provide a
> clock for sgenet1. But the driver doesn't use this clk, if the ethernet
> port is connected via SGMII. Therefore this patch avoids probing for clk
> on SGMII interfaces.
Applied, thanks.
> Fixes: 9aea7779b764 drivers: net: xgene: Fix crash on DT systems
Please put the commit header text inside of parenthesis and double quotes,
like this:
Fixes: 9aea7779b764 ("drivers: net: xgene: Fix crash on DT systems")
I fixed it up for you this time.
next prev parent reply other threads:[~2017-07-13 16:22 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-07-13 8:57 [PATCH net] xgene: Don't fail probe, if there is no clk resource for SGMII interfaces Thomas Bogendoerfer
2017-07-13 16:22 ` David Miller [this message]
2017-07-27 21:03 ` Laura Abbott
2017-07-27 21:39 ` Tom Bogendoerfer
2017-07-27 22:39 ` Laura Abbott
2017-07-28 14:23 ` Tom Bogendoerfer
2017-07-28 16:42 ` Laura Abbott
2017-07-28 18:40 ` Iyappan Subramanian
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170713.092215.720040460171963059.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=isubramanian@apm.com \
--cc=kchudgar@apm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=qnguyen@apm.com \
--cc=tsbogend@alpha.franken.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).