From: David Miller <davem@davemloft.net>
To: dsahern@gmail.com
Cc: edumazet@google.com, idosch@mellanox.com, jiri@mellanox.com,
netdev@vger.kernel.org
Subject: Re: [PATCH net] net: set fib rule refcount after malloc
Date: Thu, 13 Jul 2017 13:43:35 -0700 (PDT) [thread overview]
Message-ID: <20170713.134335.1544432096954681162.davem@davemloft.net> (raw)
In-Reply-To: <1499978200-12331-1-git-send-email-dsahern@gmail.com>
From: David Ahern <dsahern@gmail.com>
Date: Thu, 13 Jul 2017 13:36:40 -0700
> The configure callback of fib_rules_ops can change the refcnt of a
> fib rule. For instance, mlxsw takes a refcnt when adding the processing
> of the rule to a work queue. Thus the rule refcnt can not be reset to
> to 1 afterwards. Move the refcnt setting to after the allocation.
>
> Fixes: 5361e209dd30 ("net: avoid one splat in fib_nl_delrule()")
> Signed-off-by: David Ahern <dsahern@gmail.com>
Can someone keep a scoreboard of how many bugs and arbitrary
unnecessary changes get introduced because of this new refcount_t
business rather than get fixed?
I'd really like to see how that pans out over the long term especially
with all of the backporting pain this facility is going to cause.
Anyways, David I will apply this, thanks.
prev parent reply other threads:[~2017-07-13 20:43 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-07-13 20:36 [PATCH net] net: set fib rule refcount after malloc David Ahern
2017-07-13 20:43 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170713.134335.1544432096954681162.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=dsahern@gmail.com \
--cc=edumazet@google.com \
--cc=idosch@mellanox.com \
--cc=jiri@mellanox.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).