From: Dan Carpenter <dan.carpenter@oracle.com>
To: Ilya Dryomov <idryomov@gmail.com>
Cc: "Yan, Zheng" <zyan@redhat.com>, Sage Weil <sage@redhat.com>,
"David S. Miller" <davem@davemloft.net>,
Ceph Development <ceph-devel@vger.kernel.org>,
netdev <netdev@vger.kernel.org>,
kernel-janitors@vger.kernel.org
Subject: Re: [PATCH net] libceph: osdmap: Fix some NULL dereferences
Date: Thu, 13 Jul 2017 23:23:22 +0300 [thread overview]
Message-ID: <20170713202322.4joas52vuvjpx6w5@mwanda> (raw)
In-Reply-To: <CAOi1vP8tNXb7izDJXV1LzHhFMcqhFh_+_+zxsHQZnqgb_S+Etg@mail.gmail.com>
On Thu, Jul 13, 2017 at 06:13:22PM +0200, Ilya Dryomov wrote:
>
> Hi Dan,
>
> I applied osdmap_apply_incremental() hunk and fixed a similar bug in
> osdmap_decode() (it's a not NULL deref, that's why smatch didn't catch
> it).
>
No... :/ Smatch complained about it, but I somehow marked it as done
yesterday without sending a patch. Thanks for catching that.
The Smatch check is just looking for places where we do ERR_PTR(0) or
ERR_PTR(valid_ptr). That can be intentional, so there is some hand
reviewing involved.
regards,
dan carpenter
prev parent reply other threads:[~2017-07-13 20:23 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-07-13 7:45 [PATCH net] libceph: osdmap: Fix some NULL dereferences Dan Carpenter
2017-07-13 16:13 ` Ilya Dryomov
2017-07-13 20:23 ` Dan Carpenter [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170713202322.4joas52vuvjpx6w5@mwanda \
--to=dan.carpenter@oracle.com \
--cc=ceph-devel@vger.kernel.org \
--cc=davem@davemloft.net \
--cc=idryomov@gmail.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=sage@redhat.com \
--cc=zyan@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox