From: Ido Schimmel <idosch@mellanox.com>
To: David Ahern <dsahern@gmail.com>
Cc: jiri@mellanox.com, netdev@vger.kernel.org
Subject: Re: [PATCH net] mlxsw: spectrum_router: do not drop refcnt on fib rule
Date: Fri, 14 Jul 2017 00:05:38 +0300 [thread overview]
Message-ID: <20170713210538.GA20474@splinter> (raw)
In-Reply-To: <ca0fb684-34fd-0744-1d84-829c187f6d70@gmail.com>
On Thu, Jul 13, 2017 at 02:39:10PM -0600, David Ahern wrote:
> On 7/13/17 2:33 PM, Ido Schimmel wrote:
> > Remains where? It's not clear to me how you concluded mlxsw is at fault.
> > My setup is running net-next with the refcount patches and I didn't
> > observe this.
>
> Create a VRF.
BTW, this didn't show up on my dev branch as I've patches that introduce
IPv6 support where I move the rules notifications to core, after the
refcount is set to 1 and just before the netlink notification is sent.
https://github.com/idosch/linux/commit/7b17a21b1d71fc9a1969080e5fdcb90f376b73b2
prev parent reply other threads:[~2017-07-13 21:05 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-07-13 19:11 [PATCH net] mlxsw: spectrum_router: do not drop refcnt on fib rule David Ahern
2017-07-13 19:46 ` David Ahern
2017-07-13 20:33 ` Ido Schimmel
2017-07-13 20:39 ` David Ahern
2017-07-13 20:48 ` Ido Schimmel
2017-07-13 21:05 ` Ido Schimmel [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170713210538.GA20474@splinter \
--to=idosch@mellanox.com \
--cc=dsahern@gmail.com \
--cc=jiri@mellanox.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).