Netdev List
 help / color / mirror / Atom feed
From: Florian Westphal <fw@strlen.de>
To: <netdev@vger.kernel.org>
Cc: steffen.klassert@secunet.com, ilant@mellanox.com,
	Florian Westphal <fw@strlen.de>
Subject: [PATCH net-next 03/10] net: xfrm: revert to lower xfrm dst gc limit
Date: Mon, 17 Jul 2017 13:57:20 +0200	[thread overview]
Message-ID: <20170717115727.26042-4-fw@strlen.de> (raw)
In-Reply-To: <20170717115727.26042-1-fw@strlen.de>

revert c386578f1cdb4dac230395 ("xfrm: Let the flowcache handle its size by default.").

Once we remove flow cache, we don't have a flow cache limit anymore.
We must not allow (virtually) unlimited allocations of xfrm dst entries.
Revert back to the old xfrm dst gc limits.

Signed-off-by: Florian Westphal <fw@strlen.de>
---
 Documentation/networking/ip-sysctl.txt | 6 ++----
 net/ipv4/xfrm4_policy.c                | 2 +-
 net/ipv6/xfrm6_policy.c                | 2 +-
 3 files changed, 4 insertions(+), 6 deletions(-)

diff --git a/Documentation/networking/ip-sysctl.txt b/Documentation/networking/ip-sysctl.txt
index 974ab47ae53a..f485d553e65c 100644
--- a/Documentation/networking/ip-sysctl.txt
+++ b/Documentation/networking/ip-sysctl.txt
@@ -1291,8 +1291,7 @@ tag - INTEGER
 xfrm4_gc_thresh - INTEGER
 	The threshold at which we will start garbage collecting for IPv4
 	destination cache entries.  At twice this value the system will
-	refuse new allocations. The value must be set below the flowcache
-	limit (4096 * number of online cpus) to take effect.
+	refuse new allocations.
 
 igmp_link_local_mcast_reports - BOOLEAN
 	Enable IGMP reports for link local multicast groups in the
@@ -1778,8 +1777,7 @@ ratelimit - INTEGER
 xfrm6_gc_thresh - INTEGER
 	The threshold at which we will start garbage collecting for IPv6
 	destination cache entries.  At twice this value the system will
-	refuse new allocations. The value must be set below the flowcache
-	limit (4096 * number of online cpus) to take effect.
+	refuse new allocations.
 
 
 IPv6 Update by:
diff --git a/net/ipv4/xfrm4_policy.c b/net/ipv4/xfrm4_policy.c
index 71b4ecc195c7..19455a5fc328 100644
--- a/net/ipv4/xfrm4_policy.c
+++ b/net/ipv4/xfrm4_policy.c
@@ -266,7 +266,7 @@ static struct dst_ops xfrm4_dst_ops_template = {
 	.destroy =		xfrm4_dst_destroy,
 	.ifdown =		xfrm4_dst_ifdown,
 	.local_out =		__ip_local_out,
-	.gc_thresh =		INT_MAX,
+	.gc_thresh =		32768,
 };
 
 static const struct xfrm_policy_afinfo xfrm4_policy_afinfo = {
diff --git a/net/ipv6/xfrm6_policy.c b/net/ipv6/xfrm6_policy.c
index 79651bc71bf0..ae30dc4973e8 100644
--- a/net/ipv6/xfrm6_policy.c
+++ b/net/ipv6/xfrm6_policy.c
@@ -286,7 +286,7 @@ static struct dst_ops xfrm6_dst_ops_template = {
 	.destroy =		xfrm6_dst_destroy,
 	.ifdown =		xfrm6_dst_ifdown,
 	.local_out =		__ip6_local_out,
-	.gc_thresh =		INT_MAX,
+	.gc_thresh =		32768,
 };
 
 static const struct xfrm_policy_afinfo xfrm6_policy_afinfo = {
-- 
2.13.0

  parent reply	other threads:[~2017-07-17 11:57 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-07-17 11:57 [PATCH net-next 0/10] xfrm: remove flow cache Florian Westphal
2017-07-17 11:57 ` [PATCH net-next 01/10] drivers: net: add missing interrupt.h include Florian Westphal
2017-07-17 11:57 ` [PATCH net-next 02/10] vti: revert flush x-netns xfrm cache when vti interface is removed Florian Westphal
2017-07-17 11:57 ` Florian Westphal [this message]
2017-07-17 11:57 ` [PATCH net-next 04/10] xfrm_policy: bypass flow_cache_lookup Florian Westphal
2017-07-17 11:57 ` [PATCH net-next 05/10] xfrm_policy: remove always true/false branches Florian Westphal
2017-07-17 11:57 ` [PATCH net-next 06/10] xfrm_policy: kill flow to policy dir conversion Florian Westphal
2017-07-17 11:57 ` [PATCH net-next 07/10] xfrm_policy: remove xfrm_policy_lookup Florian Westphal
2017-07-17 11:57 ` [PATCH net-next 08/10] xfrm_policy: make xfrm_bundle_lookup return xfrm dst object Florian Westphal
2017-07-17 11:57 ` [PATCH net-next 09/10] xfrm: remove flow cache Florian Westphal
2017-07-17 11:57 ` [PATCH net-next 10/10] xfrm: add xdst pcpu cache Florian Westphal
2017-07-18 18:15 ` [PATCH net-next 0/10] xfrm: remove flow cache David Miller
2018-06-12 19:42   ` Kristian Evensen
2018-06-13 12:40     ` Florian Westphal
2018-06-13 13:43       ` Kristian Evensen
2018-06-18 15:46         ` Kristian Evensen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170717115727.26042-4-fw@strlen.de \
    --to=fw@strlen.de \
    --cc=ilant@mellanox.com \
    --cc=netdev@vger.kernel.org \
    --cc=steffen.klassert@secunet.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox