From: Andrew Lunn <andrew@lunn.ch>
To: Fabio Estevam <festevam@gmail.com>
Cc: davem@davemloft.net, f.fainelli@gmail.com,
netdev@vger.kernel.org, Fabio Estevam <fabio.estevam@nxp.com>
Subject: Re: [PATCH net-next] mdio_bus: Remove unneeded gpiod NULL check
Date: Mon, 17 Jul 2017 23:21:37 +0200 [thread overview]
Message-ID: <20170717212137.GD11719@lunn.ch> (raw)
In-Reply-To: <1500325749-8382-1-git-send-email-festevam@gmail.com>
On Mon, Jul 17, 2017 at 06:09:09PM -0300, Fabio Estevam wrote:
> From: Fabio Estevam <fabio.estevam@nxp.com>
>
> The gpiod API checks for NULL descriptors, so there is no need to
> duplicate the check in the driver.
> Signed-off-by: Fabio Estevam <fabio.estevam@nxp.com>
VALIDATE_DESC is ugly. But:
Reviewed-by: Andrew Lunn <andrew@lunn.ch>
Andrew
next prev parent reply other threads:[~2017-07-17 21:21 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-07-17 21:09 [PATCH net-next] mdio_bus: Remove unneeded gpiod NULL check Fabio Estevam
2017-07-17 21:21 ` Andrew Lunn [this message]
2017-07-17 23:57 ` David Miller
2017-07-18 9:56 ` Sergei Shtylyov
2017-07-18 12:39 ` Fabio Estevam
2017-07-18 12:48 ` Sergei Shtylyov
2017-07-18 12:52 ` Fabio Estevam
2017-07-18 13:02 ` Sergei Shtylyov
2017-07-18 13:09 ` Fabio Estevam
2017-07-18 13:13 ` Sergei Shtylyov
2017-07-18 13:32 ` Andrew Lunn
2017-07-19 22:37 ` Fabio Estevam
2017-08-02 11:57 ` Linus Walleij
2017-09-07 21:30 ` Woojung.Huh
2017-09-07 21:33 ` Linus Walleij
2017-09-07 21:39 ` Florian Fainelli
2017-09-07 21:51 ` Woojung.Huh
2017-09-08 19:56 ` Florian Fainelli
2017-09-08 20:03 ` Woojung.Huh
2017-09-08 23:17 ` Linus Walleij
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170717212137.GD11719@lunn.ch \
--to=andrew@lunn.ch \
--cc=davem@davemloft.net \
--cc=f.fainelli@gmail.com \
--cc=fabio.estevam@nxp.com \
--cc=festevam@gmail.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).