From: Felix Manlunas <felix.manlunas@cavium.com>
To: davem@davemloft.net
Cc: netdev@vger.kernel.org, raghu.vatsavayi@cavium.com,
derek.chickles@cavium.com, satananda.burla@cavium.com,
ricardo.farrington@cavium.com
Subject: [PATCH v2 net-next 0/3] liquidio: avoid vm low memory crashes
Date: Mon, 17 Jul 2017 17:49:20 -0700 [thread overview]
Message-ID: <20170718004920.GA1541@felix-thinkpad.cavium.com> (raw)
From: Rick Farrington <ricardo.farrington@cavium.com>
This patchset addresses issues brought about by low memory conditions
in a VM. These conditions were not seen when the driver was exercised
normally. Rather, they were brought about through manual fault injection.
They are being included in the interest of hardening the driver against
unforeseen circumstances.
1. Fix GPF in octeon_init_droq(); zero the allocated block 'recv_buf_list'.
This prevents a GPF trying to access an invalid 'recv_buf_list[i]' entry
in octeon_droq_destroy_ring_buffers() if init didn't alloc all entries.
2. Don't dereference a NULL ptr in octeon_droq_destroy_ring_buffers().
3. For defensive programming, zero the allocated block 'oct->droq[0]' in
octeon_setup_output_queues() and 'oct->instr_queue[0]' in
octeon_setup_instr_queues().
change log:
V1 -> V2:
1. Corrected syntax in 'Subject' lines; no functional or code changes.
Rick Farrington (3):
liquidio: lowmem: init allocated memory to 0
liquidio: lowmem: do not dereference null ptr
liquidio: lowmem: init allocated memory to 0
drivers/net/ethernet/cavium/liquidio/octeon_device.c | 8 ++++----
drivers/net/ethernet/cavium/liquidio/octeon_droq.c | 6 ++++--
2 files changed, 8 insertions(+), 6 deletions(-)
--
2.9.0
next reply other threads:[~2017-07-18 0:41 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-07-18 0:49 Felix Manlunas [this message]
2017-07-18 0:50 ` [PATCH v2 net-next 1/3] liquidio: lowmem: init allocated memory to 0 Felix Manlunas
2017-07-18 0:51 ` [PATCH v2 net-next 2/3] liquidio: lowmem: do not dereference null ptr Felix Manlunas
2017-07-18 0:51 ` [PATCH v2 net-next 3/3] liquidio: lowmem: init allocated memory to 0 Felix Manlunas
2017-07-18 6:23 ` [PATCH v2 net-next 0/3] liquidio: avoid vm low memory crashes Leon Romanovsky
2017-07-18 15:08 ` Ricardo Farrington
2017-07-19 20:25 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170718004920.GA1541@felix-thinkpad.cavium.com \
--to=felix.manlunas@cavium.com \
--cc=davem@davemloft.net \
--cc=derek.chickles@cavium.com \
--cc=netdev@vger.kernel.org \
--cc=raghu.vatsavayi@cavium.com \
--cc=ricardo.farrington@cavium.com \
--cc=satananda.burla@cavium.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).