From: Stephen Hemminger <stephen@networkplumber.org>
To: Matteo Croce <mcroce@redhat.com>
Cc: netdev@vger.kernel.org, Phil Sutter <phil@nwl.cc>
Subject: Re: [PATCH] netns: avoid directory traversal (was: ip netns: Make sure netns name is sane)
Date: Tue, 18 Jul 2017 17:12:30 -0700 [thread overview]
Message-ID: <20170718171230.084c804e@xeon-e3> (raw)
In-Reply-To: <20170710120831.9355-1-mcroce@redhat.com>
On Mon, 10 Jul 2017 14:08:31 +0200
Matteo Croce <mcroce@redhat.com> wrote:
> Hi Phil,
>
> I noticed that your patch still leaves an uncovered scenario, the one where the
> namespace name is "." or "..".
> Calling 'ip netns del ..' will remove /var/run which is a symlink to /run on
> most systems causing some daemons, eg. dbus, to fail.
>
> ip netns doesn't validate input, allowing creation and deletion of files
> relatives to /var/run/netns.
> This patch denies creation or deletion of namespaces with names contaning
> "/" or that matches exactly "." or "..".
> ---
> ip/ipnetns.c | 10 ++++++++++
> 1 file changed, 10 insertions(+)
>
The patch itself is good, but the commit message needs fixing.
Please rewrite it to describe the problem, and add signed-off-by
next prev parent reply other threads:[~2017-07-19 0:13 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-07-10 12:08 [PATCH] netns: avoid directory traversal (was: ip netns: Make sure netns name is sane) Matteo Croce
2017-07-10 13:07 ` Phil Sutter
2017-07-19 0:12 ` Stephen Hemminger [this message]
2017-07-19 22:36 ` [PATCH v2] " Matteo Croce
2017-07-20 7:44 ` Phil Sutter
2017-07-21 0:25 ` Stephen Hemminger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170718171230.084c804e@xeon-e3 \
--to=stephen@networkplumber.org \
--cc=mcroce@redhat.com \
--cc=netdev@vger.kernel.org \
--cc=phil@nwl.cc \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).