* [PATCH] net: ethernet: mediatek: remove useless code in mtk_poll_tx()
@ 2017-07-18 20:48 Gustavo A. R. Silva
2017-07-19 3:23 ` Sean Wang
2017-07-19 23:35 ` David Miller
0 siblings, 2 replies; 3+ messages in thread
From: Gustavo A. R. Silva @ 2017-07-18 20:48 UTC (permalink / raw)
To: Felix Fietkau, John Crispin, Matthias Brugger
Cc: netdev-u79uwXL29TY76Z2rM5mHXA,
linux-mediatek-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r,
linux-kernel-u79uwXL29TY76Z2rM5mHXA,
linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r,
Gustavo A. R. Silva
Remove useless local variable _condition_ and the code related.
Signed-off-by: Gustavo A. R. Silva <gustavo-L1vi/lXTdts+Va1GwOuvDg@public.gmane.org>
---
drivers/net/ethernet/mediatek/mtk_eth_soc.c | 5 +----
1 file changed, 1 insertion(+), 4 deletions(-)
diff --git a/drivers/net/ethernet/mediatek/mtk_eth_soc.c b/drivers/net/ethernet/mediatek/mtk_eth_soc.c
index b3d0c2e..7e95cf5 100644
--- a/drivers/net/ethernet/mediatek/mtk_eth_soc.c
+++ b/drivers/net/ethernet/mediatek/mtk_eth_soc.c
@@ -1027,7 +1027,6 @@ static int mtk_poll_tx(struct mtk_eth *eth, int budget)
unsigned int done[MTK_MAX_DEVS];
unsigned int bytes[MTK_MAX_DEVS];
u32 cpu, dma;
- static int condition;
int total = 0, i;
memset(done, 0, sizeof(done));
@@ -1051,10 +1050,8 @@ static int mtk_poll_tx(struct mtk_eth *eth, int budget)
mac = 1;
skb = tx_buf->skb;
- if (!skb) {
- condition = 1;
+ if (!skb)
break;
- }
if (skb != (struct sk_buff *)MTK_DMA_DUMMY_DESC) {
bytes[mac] += skb->len;
--
2.5.0
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] net: ethernet: mediatek: remove useless code in mtk_poll_tx()
2017-07-18 20:48 [PATCH] net: ethernet: mediatek: remove useless code in mtk_poll_tx() Gustavo A. R. Silva
@ 2017-07-19 3:23 ` Sean Wang
2017-07-19 23:35 ` David Miller
1 sibling, 0 replies; 3+ messages in thread
From: Sean Wang @ 2017-07-19 3:23 UTC (permalink / raw)
To: Gustavo A. R. Silva
Cc: Felix Fietkau, John Crispin, Matthias Brugger, netdev,
linux-mediatek, linux-kernel, linux-arm-kernel
On Tue, 2017-07-18 at 15:48 -0500, Gustavo A. R. Silva wrote:
> Remove useless local variable _condition_ and the code related.
>
> Signed-off-by: Gustavo A. R. Silva <gustavo@embeddedor.com>
> ---
> drivers/net/ethernet/mediatek/mtk_eth_soc.c | 5 +----
> 1 file changed, 1 insertion(+), 4 deletions(-)
>
> diff --git a/drivers/net/ethernet/mediatek/mtk_eth_soc.c b/drivers/net/ethernet/mediatek/mtk_eth_soc.c
> index b3d0c2e..7e95cf5 100644
> --- a/drivers/net/ethernet/mediatek/mtk_eth_soc.c
> +++ b/drivers/net/ethernet/mediatek/mtk_eth_soc.c
> @@ -1027,7 +1027,6 @@ static int mtk_poll_tx(struct mtk_eth *eth, int budget)
> unsigned int done[MTK_MAX_DEVS];
> unsigned int bytes[MTK_MAX_DEVS];
> u32 cpu, dma;
> - static int condition;
> int total = 0, i;
>
> memset(done, 0, sizeof(done));
> @@ -1051,10 +1050,8 @@ static int mtk_poll_tx(struct mtk_eth *eth, int budget)
> mac = 1;
>
> skb = tx_buf->skb;
> - if (!skb) {
> - condition = 1;
> + if (!skb)
> break;
> - }
>
> if (skb != (struct sk_buff *)MTK_DMA_DUMMY_DESC) {
> bytes[mac] += skb->len;
Acked-by: Sean Wang <sean.wang@mediatek.com>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] net: ethernet: mediatek: remove useless code in mtk_poll_tx()
2017-07-18 20:48 [PATCH] net: ethernet: mediatek: remove useless code in mtk_poll_tx() Gustavo A. R. Silva
2017-07-19 3:23 ` Sean Wang
@ 2017-07-19 23:35 ` David Miller
1 sibling, 0 replies; 3+ messages in thread
From: David Miller @ 2017-07-19 23:35 UTC (permalink / raw)
To: gustavo
Cc: nbd, blogic, matthias.bgg, netdev, linux-arm-kernel,
linux-mediatek, linux-kernel
From: "Gustavo A. R. Silva" <gustavo@embeddedor.com>
Date: Tue, 18 Jul 2017 15:48:06 -0500
> Remove useless local variable _condition_ and the code related.
>
> Signed-off-by: Gustavo A. R. Silva <gustavo@embeddedor.com>
Applied.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2017-07-19 23:35 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2017-07-18 20:48 [PATCH] net: ethernet: mediatek: remove useless code in mtk_poll_tx() Gustavo A. R. Silva
2017-07-19 3:23 ` Sean Wang
2017-07-19 23:35 ` David Miller
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).