netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: David Miller <davem@davemloft.net>
To: girish.moodalbail@oracle.com
Cc: pshelar@ovn.org, netdev@vger.kernel.org
Subject: Re: [PATCH net-next v2 1/1] geneve: add rtnl changelink support
Date: Wed, 19 Jul 2017 16:51:16 -0700 (PDT)	[thread overview]
Message-ID: <20170719.165116.1585585461311289445.davem@davemloft.net> (raw)
In-Reply-To: <1500420786-11993-1-git-send-email-girish.moodalbail@oracle.com>

From: Girish Moodalbail <girish.moodalbail@oracle.com>
Date: Tue, 18 Jul 2017 16:33:06 -0700

> +static inline bool geneve_dst_addr_equal(struct ip_tunnel_info *a,
 ...
> +static inline void geneve_quiesce(struct geneve_dev *geneve,
 ...
> +static inline void geneve_unquiesce(struct geneve_dev *geneve,

Please no inline functions in foo.c files, let the compiler
decide.

Thanks.

  reply	other threads:[~2017-07-19 23:51 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-07-18 23:33 [PATCH net-next v2 1/1] geneve: add rtnl changelink support Girish Moodalbail
2017-07-19 23:51 ` David Miller [this message]
2017-07-20  3:08   ` Girish Moodalbail
2017-07-20  3:18 ` Pravin Shelar
2017-07-20 17:42   ` Girish Moodalbail
2017-07-20 17:58     ` Pravin Shelar

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170719.165116.1585585461311289445.davem@davemloft.net \
    --to=davem@davemloft.net \
    --cc=girish.moodalbail@oracle.com \
    --cc=netdev@vger.kernel.org \
    --cc=pshelar@ovn.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).