From: David Miller <davem@davemloft.net>
To: jqiaoulk@gmail.com
Cc: f.fainelli@gmail.com, netdev@vger.kernel.org
Subject: Re: [PATCH v2 net-next] net: systemport: Support 64bit statistics
Date: Wed, 19 Jul 2017 22:25:16 -0700 (PDT) [thread overview]
Message-ID: <20170719.222516.1490852598794069450.davem@davemloft.net> (raw)
In-Reply-To: <1500423520-4169-1-git-send-email-jqiaoulk@gmail.com>
From: "Jianming.qiao" <jqiaoulk@gmail.com>
Date: Wed, 19 Jul 2017 01:18:40 +0100
> Signed-off-by: Jianming.qiao <kiki-good@hotmail.com>
Supporting both deprecated .ndo_get_stats and 64-bit .ndo_get_stats64
at the same time makes no sense.
.ndo_get_stats will never be called if .ndo_get_stats64 is non-NULL
The lack of a commit log message, explaining in detail, why you are
doing this and why you are doing it this way, concerns me as well.
This submission so far has been a bit of a mess. You don't
communicate enough, your commit message is empty, and therefore we
have no idea why you are doing things, and in particular the reasons
for your decisions.
I'm not applying this, sorry.
next prev parent reply other threads:[~2017-07-20 5:25 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-07-19 0:18 [PATCH v2 net-next] net: systemport: Support 64bit statistics Jianming.qiao
2017-07-20 5:25 ` David Miller [this message]
2017-07-20 10:13 ` kiki good
2017-07-20 15:28 ` Florian Fainelli
2017-07-20 15:44 ` Stephen Hemminger
2017-07-20 21:59 ` kiki good
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170719.222516.1490852598794069450.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=f.fainelli@gmail.com \
--cc=jqiaoulk@gmail.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).