* [PATCH] net: dsa: mv88e6xxx: Enable CMODE config support for 6390X
@ 2017-07-19 6:17 Martin Hundebøll
2017-07-19 13:25 ` Andrew Lunn
` (2 more replies)
0 siblings, 3 replies; 4+ messages in thread
From: Martin Hundebøll @ 2017-07-19 6:17 UTC (permalink / raw)
To: David S . Miller
Cc: Martin Hundebøll, netdev, Vivien Didelot, Florian Fainelli,
Andrew Lunn
Commit f39908d3b1c45 ('net: dsa: mv88e6xxx: Set the CMODE for mv88e6390
ports 9 & 10') added support for setting the CMODE for the 6390X family,
but only enabled it for 9290 and 6390 - and left out 6390X.
Fix support for setting the CMODE on 6390X also by assigning
mv88e6390x_port_set_cmode() to the .port_set_cmode function pointer in
mv88e6390x_ops too.
Signed-off-by: Martin Hundebøll <mnhu@prevas.dk>
---
drivers/net/dsa/mv88e6xxx/chip.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/net/dsa/mv88e6xxx/chip.c b/drivers/net/dsa/mv88e6xxx/chip.c
index 947ea352a57a..7fa19d4a8e13 100644
--- a/drivers/net/dsa/mv88e6xxx/chip.c
+++ b/drivers/net/dsa/mv88e6xxx/chip.c
@@ -3233,6 +3233,7 @@ static const struct mv88e6xxx_ops mv88e6390x_ops = {
.port_set_jumbo_size = mv88e6165_port_set_jumbo_size,
.port_egress_rate_limiting = mv88e6097_port_egress_rate_limiting,
.port_pause_limit = mv88e6390_port_pause_limit,
+ .port_set_cmode = mv88e6390x_port_set_cmode,
.port_disable_learn_limit = mv88e6xxx_port_disable_learn_limit,
.port_disable_pri_override = mv88e6xxx_port_disable_pri_override,
.stats_snapshot = mv88e6390_g1_stats_snapshot,
--
2.13.3
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH] net: dsa: mv88e6xxx: Enable CMODE config support for 6390X
2017-07-19 6:17 [PATCH] net: dsa: mv88e6xxx: Enable CMODE config support for 6390X Martin Hundebøll
@ 2017-07-19 13:25 ` Andrew Lunn
2017-07-19 16:55 ` Vivien Didelot
2017-07-20 5:26 ` David Miller
2 siblings, 0 replies; 4+ messages in thread
From: Andrew Lunn @ 2017-07-19 13:25 UTC (permalink / raw)
To: Martin Hundebøll
Cc: David S . Miller, netdev, Vivien Didelot, Florian Fainelli
On Wed, Jul 19, 2017 at 08:17:02AM +0200, Martin Hundebøll wrote:
> Commit f39908d3b1c45 ('net: dsa: mv88e6xxx: Set the CMODE for mv88e6390
> ports 9 & 10') added support for setting the CMODE for the 6390X family,
> but only enabled it for 9290 and 6390 - and left out 6390X.
>
> Fix support for setting the CMODE on 6390X also by assigning
> mv88e6390x_port_set_cmode() to the .port_set_cmode function pointer in
> mv88e6390x_ops too.
>
> Signed-off-by: Martin Hundebøll <mnhu@prevas.dk>
Duh!
Fixes: f39908d3b1c4 ("net: dsa: mv88e6xxx: Set the CMODE for mv88e6390 ports 9 & 10")
Reviewed-by: Andrew Lunn <andrew@lunn.ch>
Andrew
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] net: dsa: mv88e6xxx: Enable CMODE config support for 6390X
2017-07-19 6:17 [PATCH] net: dsa: mv88e6xxx: Enable CMODE config support for 6390X Martin Hundebøll
2017-07-19 13:25 ` Andrew Lunn
@ 2017-07-19 16:55 ` Vivien Didelot
2017-07-20 5:26 ` David Miller
2 siblings, 0 replies; 4+ messages in thread
From: Vivien Didelot @ 2017-07-19 16:55 UTC (permalink / raw)
To: Martin Hundebøll, David S . Miller
Cc: Martin Hundebøll, netdev, Florian Fainelli, Andrew Lunn
Martin Hundebøll <mnhu@prevas.dk> writes:
> Commit f39908d3b1c45 ('net: dsa: mv88e6xxx: Set the CMODE for mv88e6390
> ports 9 & 10') added support for setting the CMODE for the 6390X family,
> but only enabled it for 9290 and 6390 - and left out 6390X.
>
> Fix support for setting the CMODE on 6390X also by assigning
> mv88e6390x_port_set_cmode() to the .port_set_cmode function pointer in
> mv88e6390x_ops too.
>
> Signed-off-by: Martin Hundebøll <mnhu@prevas.dk>
Reviewed-by: Vivien Didelot <vivien.didelot@savoirfairelinux.com>
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] net: dsa: mv88e6xxx: Enable CMODE config support for 6390X
2017-07-19 6:17 [PATCH] net: dsa: mv88e6xxx: Enable CMODE config support for 6390X Martin Hundebøll
2017-07-19 13:25 ` Andrew Lunn
2017-07-19 16:55 ` Vivien Didelot
@ 2017-07-20 5:26 ` David Miller
2 siblings, 0 replies; 4+ messages in thread
From: David Miller @ 2017-07-20 5:26 UTC (permalink / raw)
To: mnhu; +Cc: netdev, vivien.didelot, f.fainelli, andrew
From: Martin Hundebøll <mnhu@prevas.dk>
Date: Wed, 19 Jul 2017 08:17:02 +0200
> Commit f39908d3b1c45 ('net: dsa: mv88e6xxx: Set the CMODE for mv88e6390
> ports 9 & 10') added support for setting the CMODE for the 6390X family,
> but only enabled it for 9290 and 6390 - and left out 6390X.
>
> Fix support for setting the CMODE on 6390X also by assigning
> mv88e6390x_port_set_cmode() to the .port_set_cmode function pointer in
> mv88e6390x_ops too.
>
> Signed-off-by: Martin Hundebøll <mnhu@prevas.dk>
Applied and queued up for -stable, thanks.
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2017-07-20 5:26 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2017-07-19 6:17 [PATCH] net: dsa: mv88e6xxx: Enable CMODE config support for 6390X Martin Hundebøll
2017-07-19 13:25 ` Andrew Lunn
2017-07-19 16:55 ` Vivien Didelot
2017-07-20 5:26 ` David Miller
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).