From: Stephen Hemminger <stephen@networkplumber.org>
To: "Philip Prindeville" <philipp@redfish-solutions.com>
Cc: netdev@vger.kernel.org, Michele Lucini <mlucini@safearea.com.au>
Subject: Re: [PATCH v2 1/1] iroute2: Add support for GRE ignore-df knob
Date: Thu, 20 Jul 2017 08:42:35 -0700 [thread overview]
Message-ID: <20170720084235.691873e0@xeon-e3> (raw)
In-Reply-To: <20170720051933.5051-1-philipp@redfish-solutions.com>
On Wed, 19 Jul 2017 23:19:33 -0600
"Philip Prindeville" <philipp@redfish-solutions.com> wrote:
> From: Philip Prindeville <philipp@redfish-solutions.com>
>
> In the presence of firewalls which improperly block ICMP Unreachable
> (including Fragmentation Required) messages, Path MTU Discovery is
> prevented from working.
>
> The workaround is to handle IPv4 payloads opaquely, ignoring the DF bit.
>
> Reviewed-by: Stephen Hemminger <stephen@networkplumber.org>
> Signed-off-by: Philip Prindeville <philipp@redfish-solutions.com>
> ---
> doc/ip-cref.tex | 7 +++++++
> ip/link_gre.c | 16 ++++++++++++++++
> man/man8/ip-tunnel.8 | 9 +++++++++
> 3 files changed, 32 insertions(+)
>
Please fix Subject line and the following minor checkpatch warnings and resubmit
WARNING: line over 80 characters
#109: FILE: ip/link_gre.c:170:
+ ignore_df = !!rta_getattr_u8(greinfo[IFLA_GRE_IGNORE_DF]);
WARNING: Block comments use a trailing */ on a separate line
#121: FILE: ip/link_gre.c:322:
+ // only the lsb is significant, use 2 for presence */
total: 0 errors, 2 warnings, 86 lines checked
prev parent reply other threads:[~2017-07-20 15:42 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-07-20 5:19 [PATCH v2 1/1] iroute2: Add support for GRE ignore-df knob Philip Prindeville
2017-07-20 15:42 ` Stephen Hemminger [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170720084235.691873e0@xeon-e3 \
--to=stephen@networkplumber.org \
--cc=mlucini@safearea.com.au \
--cc=netdev@vger.kernel.org \
--cc=philipp@redfish-solutions.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).