From: lsorense@csclub.uwaterloo.ca (Lennart Sorensen)
To: Benjamin Poirier <bpoirier@suse.com>
Cc: linux-kernel@vger.kernel.org, netdev@vger.kernel.org,
intel-wired-lan@lists.osuosl.org,
Jeff Kirsher <jeffrey.t.kirsher@intel.com>
Subject: Re: commit 16ecba59 breaks 82574L under heavy load.
Date: Thu, 20 Jul 2017 10:00:27 -0400 [thread overview]
Message-ID: <20170720140027.GR18556@csclub.uwaterloo.ca> (raw)
In-Reply-To: <20170720000747.4jiadqubv7hg5esz@f1.synalogic.ca>
On Wed, Jul 19, 2017 at 05:07:47PM -0700, Benjamin Poirier wrote:
> Are you sure about this? In my testing, while triggering the overrun
> with the msleep, I read ICR when entering e1000_msix_other() and RXO is
> consistently set.
I had thousands of calls to e1000_msix_other where the only bit set
was OTHER.
I don't know if the cause is overruns, it just seems plausible.
> I'm working on a patch that uses that fact to handle the situation and
> limit the interrupt.
Excellent.
Running in MSI mode rather than MSI-X seems to not have the problem of
unexpected interrupts, but has other issues (such as loosing the IRQ
affinity setting if you do ifconfig down;ifconfig up on the interface,
which does not happen in MSI-X's case.) That's rather annoying as you
can't set the affinity before bringing up the interface which is rather
undesirable.
--
Len Sorensen
next prev parent reply other threads:[~2017-07-20 14:00 UTC|newest]
Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-07-18 14:21 commit 16ecba59 breaks 82574L under heavy load Lennart Sorensen
2017-07-18 23:14 ` Benjamin Poirier
2017-07-19 14:19 ` Lennart Sorensen
2017-07-20 0:07 ` Benjamin Poirier
2017-07-20 14:00 ` Lennart Sorensen [this message]
2017-07-20 23:44 ` Benjamin Poirier
2017-07-21 15:27 ` Lennart Sorensen
2017-07-21 16:09 ` Lennart Sorensen
2017-07-21 18:36 ` [PATCH 1/5] e1000e: Fix error path in link detection Benjamin Poirier
2017-07-21 18:36 ` [PATCH 2/5] e1000e: Fix wrong comment related to " Benjamin Poirier
2017-09-19 0:13 ` [Intel-wired-lan] " Brown, Aaron F
2017-07-21 18:36 ` [PATCH 3/5] e1000e: Fix return value test Benjamin Poirier
2017-09-15 0:20 ` [Intel-wired-lan] " Brown, Aaron F
2017-07-21 18:36 ` [PATCH 4/5] e1000e: Separate signaling for link check/link up Benjamin Poirier
2017-07-21 18:50 ` Lennart Sorensen
2017-08-02 11:28 ` [Intel-wired-lan] " Neftin, Sasha
2017-08-02 14:34 ` Lennart Sorensen
2017-08-02 14:49 ` Benjamin Poirier
2017-09-15 0:27 ` Brown, Aaron F
2017-07-21 18:36 ` [PATCH 5/5] e1000e: Avoid receiver overrun interrupt bursts Benjamin Poirier
2017-07-21 18:48 ` Lennart Sorensen
2017-08-12 2:13 ` Philip Prindeville
2017-08-12 2:47 ` Philip Prindeville
2017-08-21 17:17 ` Benjamin Poirier
2017-09-15 0:38 ` [Intel-wired-lan] " Brown, Aaron F
2017-09-19 18:38 ` [5/5] " Philip Prindeville
2017-09-19 19:41 ` Benjamin Poirier
2017-10-24 17:20 ` Lennart Sorensen
2017-10-24 17:39 ` Philip Prindeville
2017-09-15 0:18 ` [Intel-wired-lan] [PATCH 1/5] e1000e: Fix error path in link detection Brown, Aaron F
2017-07-21 19:02 ` commit 16ecba59 breaks 82574L under heavy load Lennart Sorensen
2017-07-24 21:56 ` Philip Prindeville
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170720140027.GR18556@csclub.uwaterloo.ca \
--to=lsorense@csclub.uwaterloo.ca \
--cc=bpoirier@suse.com \
--cc=intel-wired-lan@lists.osuosl.org \
--cc=jeffrey.t.kirsher@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).