From: Stephen Hemminger <stephen@networkplumber.org>
To: Matteo Croce <mcroce@redhat.com>
Cc: Phil Sutter <phil@nwl.cc>, netdev@vger.kernel.org
Subject: Re: [PATCH v2] netns: avoid directory traversal (was: ip netns: Make sure netns name is sane)
Date: Thu, 20 Jul 2017 17:25:21 -0700 [thread overview]
Message-ID: <20170720172521.3fd57f26@xeon-e3> (raw)
In-Reply-To: <20170719223632.4124-1-mcroce@redhat.com>
On Thu, 20 Jul 2017 00:36:32 +0200
Matteo Croce <mcroce@redhat.com> wrote:
> v2: reword commit message
>
> ip netns keeps track of created namespaces with bind mounts named
> /var/run/netns/<namespace>. No input sanitization is done, allowing creation and
> deletion of files relatives to /var/run/netns or, if the path is non existent or
> invalid, allows to create "untracked" namespaces (invisible to the tool).
>
> This commit denies creation or deletion of namespaces with names contaning
> "/" or matching exactly "." or "..".
>
> Signed-off-by: Matteo Croce <mcroce@redhat.com>
Applied. I manually edited the commit description to remove the (was...)
thanks Matteo.
prev parent reply other threads:[~2017-07-21 0:25 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-07-10 12:08 [PATCH] netns: avoid directory traversal (was: ip netns: Make sure netns name is sane) Matteo Croce
2017-07-10 13:07 ` Phil Sutter
2017-07-19 0:12 ` Stephen Hemminger
2017-07-19 22:36 ` [PATCH v2] " Matteo Croce
2017-07-20 7:44 ` Phil Sutter
2017-07-21 0:25 ` Stephen Hemminger [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170720172521.3fd57f26@xeon-e3 \
--to=stephen@networkplumber.org \
--cc=mcroce@redhat.com \
--cc=netdev@vger.kernel.org \
--cc=phil@nwl.cc \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).