[PATCH 00/13] net: dsa: lan9303: unicast offload, fdb,mdb,STP

[PATCH 00/13] net: dsa: lan9303: unicast offload, fdb,mdb,STP

[Egil Hjelmeland]

This series extends the LAN9303 3 port switch DSA driver. Highlights:
 - Make the MDIO interface work
 - Bridging: Unicast offload
 - Bridging: Added fdb/mdb handling
 - Bridging: STP support
 - Documentation

The last three patches are workarounds due to current kernel limitations.

This is my first patches submitted to the kernel, so I am looking
forward to comments.


Egil Hjelmeland (13):
  net: dsa: lan9303: Fixed MDIO interface
  net: dsa: lan9303: Do not disable/enable switch fabric port 0 at
    startup
  net: dsa: lan9303: Refactor lan9303_enable_packet_processing()
  net: dsa: lan9303: Added adjust_link() method
  net: dsa: added dsa_net_device_to_dsa_port()
  net: dsa: lan9303: added sysfs node swe_bcst_throt
  net: dsa: lan9303: Added basic offloading of unicast traffic
  net: dsa: lan9303: Added ALR/fdb/mdb handling
  net: dsa: lan9303: Added Documentation/networking/dsa/lan9303.txt
  net: dsa: lan9303: Only allocate 3 ports
  net: dsa: lan9303: Added "alr_dump" sysfs port attribute
  net: dsa: lan9303: Added "stp_enable" sysfs attribute
  net: dsa: lan9303: lan9303_port_mdb_del remove port 0

 Documentation/networking/dsa/lan9303.txt |  74 +++
 drivers/net/dsa/lan9303-core.c           | 811 ++++++++++++++++++++++++++++---
 drivers/net/dsa/lan9303.h                |  23 +
 drivers/net/dsa/lan9303_i2c.c            |   2 +
 drivers/net/dsa/lan9303_mdio.c           |  34 ++
 include/net/dsa.h                        |   1 +
 net/dsa/slave.c                          |  10 +
 7 files changed, 885 insertions(+), 70 deletions(-)
 create mode 100644 Documentation/networking/dsa/lan9303.txt

-- 
2.11.0


DISCLAIMER:
This e-mail may contain confidential and privileged material for the sole use of the intended recipient. Any review, use, distribution or disclosure by others is strictly prohibited. If you are not the intended recipient (or authorized to receive for the recipient), please contact the sender by reply e-mail and delete all copies of this message.

Re: [PATCH 00/13] net: dsa: lan9303: unicast offload, fdb,mdb,STP

[Florian Fainelli]

Hi,

On 07/24/2017 07:47 AM, Egil Hjelmeland wrote:
> This series extends the LAN9303 3 port switch DSA driver. Highlights:
>  - Make the MDIO interface work
>  - Bridging: Unicast offload
>  - Bridging: Added fdb/mdb handling
>  - Bridging: STP support
>  - Documentation
> 
> The last three patches are workarounds due to current kernel limitations.
> 
> This is my first patches submitted to the kernel, so I am looking
> forward to comments.

First thing would be to get your patch submissions square, because the
patches do not appear to have been sent as a reply to this cover letter,
and worse yet, they are all appearing with their commit date, which is
highly confusing since that makes them go back in time for some of them.

I will reply to the other patches as well.

> 
> 
> Egil Hjelmeland (13):
>   net: dsa: lan9303: Fixed MDIO interface
>   net: dsa: lan9303: Do not disable/enable switch fabric port 0 at
>     startup
>   net: dsa: lan9303: Refactor lan9303_enable_packet_processing()
>   net: dsa: lan9303: Added adjust_link() method
>   net: dsa: added dsa_net_device_to_dsa_port()
>   net: dsa: lan9303: added sysfs node swe_bcst_throt
>   net: dsa: lan9303: Added basic offloading of unicast traffic
>   net: dsa: lan9303: Added ALR/fdb/mdb handling
>   net: dsa: lan9303: Added Documentation/networking/dsa/lan9303.txt
>   net: dsa: lan9303: Only allocate 3 ports
>   net: dsa: lan9303: Added "alr_dump" sysfs port attribute
>   net: dsa: lan9303: Added "stp_enable" sysfs attribute
>   net: dsa: lan9303: lan9303_port_mdb_del remove port 0
> 
>  Documentation/networking/dsa/lan9303.txt |  74 +++
>  drivers/net/dsa/lan9303-core.c           | 811 ++++++++++++++++++++++++++++---
>  drivers/net/dsa/lan9303.h                |  23 +
>  drivers/net/dsa/lan9303_i2c.c            |   2 +
>  drivers/net/dsa/lan9303_mdio.c           |  34 ++
>  include/net/dsa.h                        |   1 +
>  net/dsa/slave.c                          |  10 +
>  7 files changed, 885 insertions(+), 70 deletions(-)
>  create mode 100644 Documentation/networking/dsa/lan9303.txt
> 


-- 
Florian

Re: [PATCH 00/13] net: dsa: lan9303: unicast offload, fdb,mdb,STP

[David Miller]

From: Egil Hjelmeland <egil.hjelmeland@zenitel.com>
Date: Mon, 24 Jul 2017 16:47:51 +0200

> This is my first patches submitted to the kernel, so I am looking
> forward to comments.

Please clean up how the dates are handled in your submission.

They are all over the place, over a period of 3 days.

Instead, they should be consequentive, near the moment the patch is
submitted.

We manage patches in patchwork, and there the patches are ordered in
my queue based upon date.  So instead of a nice clean order of changes
showing up recently at the top of my queue, your's got mixed in deep
near the bottom of the queue, intermixed with other unrelated changes.

This seriously makes things more difficult for me.

The best thing to do is to apply your series into a fresh tree (which
you pretty much _MUST_ do anyways, to make sure your changes apply,
build and work properly in my GIT tree, right?) and then extract those
commits for your patch series emails.

You must also say in your subject line which of my two GIT networking
trees ('net' or 'net-next') your changes are targetting.  If you don't
know, you need to figure that out before submitting.

I'm not applying this series until you fix your process up.

Thank you.

Re: [PATCH 00/13] net: dsa: lan9303: unicast offload, fdb,mdb,STP

[Egil Hjelmeland]

On 24. juli 2017 18:54, Florian Fainelli wrote:
> 
> First thing would be to get your patch submissions square, because the
> patches do not appear to have been sent as a reply to this cover letter,
> and worse yet, they are all appearing with their commit date, which is
> highly confusing since that makes them go back in time for some of them.
> 

Hi all!

I am very sorry for the email-thread mess. Once the emails showed up on 
the spinics mirror I realized I had made a fool of my self. I see now 
that I have to add --thread to "git format-patch", when _not_ using 
"git send-email" as the backend. (I did not get "git send-email" to work
with the company email server.)

I had noted that "git format-patch" preserved commit dates, but I
wrongly thought that was "a feature, not a bug". From now on I will
make sure to "git rebase --ignore-date master".

Egil

DISCLAIMER:
This e-mail may contain confidential and privileged material for the sole use of the intended recipient. Any review, use, distribution or disclosure by others is strictly prohibited. If you are not the intended recipient (or authorized to receive for the recipient), please contact the sender by reply e-mail and delete all copies of this message.

Re: [PATCH 00/13] net: dsa: lan9303: unicast offload, fdb,mdb,STP

[Egil Hjelmeland]

On 24. juli 2017 22:32, David Miller wrote:
> 
> They are all over the place, over a period of 3 days.
I will do "git rebase --ignore-date master" from now on.

> You must also say in your subject line which of my two GIT networking
> trees ('net' or 'net-next') your changes are targetting.  If you don't
> know, you need to figure that out before submitting.

Makes sense. I just found Documentation/networking/netdev-FAQ.txt,
reading that made it even clearer.

> I'm not applying this series until you fix your process up.

No problem, I did not expect first version to go through anyway.

Egil



DISCLAIMER:
This e-mail may contain confidential and privileged material for the sole use of the intended recipient. Any review, use, distribution or disclosure by others is strictly prohibited. If you are not the intended recipient (or authorized to receive for the recipient), please contact the sender by reply e-mail and delete all copies of this message.