From mboxrd@z Thu Jan 1 00:00:00 1970 From: David Miller Subject: Re: [PATCH] of_mdio: kill useless variable in of_phy_register_fixed_link() Date: Mon, 24 Jul 2017 16:28:21 -0700 (PDT) Message-ID: <20170724.162821.65962444296157910.davem@davemloft.net> References: <20170723184612.321910595@cogentembedded.com> Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit Cc: andrew-g2DYL2Zd6BY@public.gmane.org, f.fainelli-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org, robh+dt-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org, frowand.list-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org, netdev-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: sergei.shtylyov-M4DtvfQ/ZS1MRgGoP+s0PdBPR1lH4CV8@public.gmane.org Return-path: In-Reply-To: <20170723184612.321910595-M4DtvfQ/ZS1MRgGoP+s0PdBPR1lH4CV8@public.gmane.org> Sender: devicetree-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org List-Id: netdev.vger.kernel.org From: Sergei Shtylyov Date: Sun, 23 Jul 2017 21:45:47 +0300 > of_phy_register_fixed_link() declares the 'err' variable to hold the result > of of_property_read_string() but only uses it once after that, while that > function can be called directly from the *if* statement... > > Remove that variable and move/regroup 'link_gpio' and 'len' variables in > order to sort the declarations in the reverse Xmas tree order -- to please > DaveM. ;-) Respect MY AUTHORITY! :-) > Signed-off-by: Sergei Shtylyov Applied, thanks. -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html