Netdev List
 help / color / mirror / Atom feed
From: David Miller <davem@davemloft.net>
To: jakub.kicinski@netronome.com
Cc: netdev@vger.kernel.org, oss-drivers@netronome.com,
	dirk.vandermerwe@netronome.com
Subject: Re: [PATCH net-next] nfp: set config bit (ifup/ifdown) on netdev open/close
Date: Tue, 25 Jul 2017 12:29:58 -0700 (PDT)	[thread overview]
Message-ID: <20170725.122958.2257952323982979614.davem@davemloft.net> (raw)
In-Reply-To: <20170725075108.18537-1-jakub.kicinski@netronome.com>

From: Jakub Kicinski <jakub.kicinski@netronome.com>
Date: Tue, 25 Jul 2017 00:51:08 -0700

> From: Dirk van der Merwe <dirk.vandermerwe@netronome.com>
> 
> When a netdev (PF netdev or representor) is opened or closed, set the
> physical port config bit appropriately - which powers UP/DOWN the PHY
> module for the physical interface.
> 
> The PHY is powered first in the HW/FW configuration step when opening
> the netdev and again last in the HW/FW configuration step when closing
> the netdev.
> 
> This is only applicable when there is a physical port associated with
> the netdev and if the NSP support this. Otherwise we silently ignore
> this step.
> 
> The 'nfp_eth_set_configured' can actually return positive values -
> updated the function documentation appropriately.
> 
> Signed-off-by: Dirk van der Merwe <dirk.vandermerwe@netronome.com>
> Reviewed-by: Jakub Kicinski <jakub.kicinski@netronome.com>

Applied, thanks Jakub.

      reply	other threads:[~2017-07-25 19:29 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-07-25  7:51 [PATCH net-next] nfp: set config bit (ifup/ifdown) on netdev open/close Jakub Kicinski
2017-07-25 19:29 ` David Miller [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170725.122958.2257952323982979614.davem@davemloft.net \
    --to=davem@davemloft.net \
    --cc=dirk.vandermerwe@netronome.com \
    --cc=jakub.kicinski@netronome.com \
    --cc=netdev@vger.kernel.org \
    --cc=oss-drivers@netronome.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox