From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jakub Kicinski Subject: [RFC] switchdev: clarify ndo_get_phys_port_name() formats Date: Mon, 24 Jul 2017 22:13:44 -0700 Message-ID: <20170725051344.2040-1-jakub.kicinski@netronome.com> References: <20170724214521.75bf5857@cakuba.netronome.com> Cc: Jiri Pirko , Or Gerlitz , Michael Chan , Sathya Perla , simon.horman@netronome.com, davem@davemloft.net, Jakub Kicinski To: netdev@vger.kernel.org Return-path: Received: from mail-pf0-f174.google.com ([209.85.192.174]:33055 "EHLO mail-pf0-f174.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750726AbdGYFPD (ORCPT ); Tue, 25 Jul 2017 01:15:03 -0400 Received: by mail-pf0-f174.google.com with SMTP id s70so54835242pfs.0 for ; Mon, 24 Jul 2017 22:15:03 -0700 (PDT) In-Reply-To: <20170724214521.75bf5857@cakuba.netronome.com> Sender: netdev-owner@vger.kernel.org List-ID: We are still in position where we can suggest uniform naming convention for ndo_get_phys_port_name(). switchdev.txt file already contained a suggestion of how to name external ports. Since the use of switchdev for SR-IOV NIC's eswitches is growing, establish a format for ports of those devices as well. Signed-off-by: Jakub Kicinski --- Documentation/networking/switchdev.txt | 14 +++++++++++--- 1 file changed, 11 insertions(+), 3 deletions(-) diff --git a/Documentation/networking/switchdev.txt b/Documentation/networking/switchdev.txt index 3e7b946dea27..7c4b6025fb4b 100644 --- a/Documentation/networking/switchdev.txt +++ b/Documentation/networking/switchdev.txt @@ -119,9 +119,17 @@ into 4 10G ports, resulting in 4 port netdevs, the device can give a unique SUBSYSTEM=="net", ACTION=="add", ATTR{phys_switch_id}=="", \ ATTR{phys_port_name}!="", NAME="swX$attr{phys_port_name}" -Suggested naming convention is "swXpYsZ", where X is the switch name or ID, Y -is the port name or ID, and Z is the sub-port name or ID. For example, sw1p1s0 -would be sub-port 0 on port 1 on switch 1. +Suggested formats of the port name returned by ndo_get_phys_port_name are: + - pA for external ports; + - pAsB for split external ports; + - pfC for PF ports (so called PF representors); + - pfCvfD for VF ports (so called VF representors). +Where A is the port name or ID; B is the sub-port name or ID; C is PCIe +Physical Function name or ID and D is PCIe Virtual Function name or ID. + +Suggested naming convention for switches is "swX", where X is the switch name +or ID, plus the port name. For example, sw1p1s0 would be sub-port 0 on port 1 +on switch 1. Port Features ^^^^^^^^^^^^^ -- 2.11.0