From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jiri Pirko Subject: Re: [PATCH net-next v11 4/4] net sched actions: add time filter for action dumping Date: Tue, 25 Jul 2017 13:34:52 +0200 Message-ID: <20170725113452.GB3186@nanopsycho> References: <1500860146-26970-1-git-send-email-jhs@emojatatu.com> <1500860146-26970-5-git-send-email-jhs@emojatatu.com> <20170724113450.GD1868@nanopsycho> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: davem@davemloft.net, netdev@vger.kernel.org, xiyou.wangcong@gmail.com, dsahern@gmail.com, eric.dumazet@gmail.com, mrv@mojatatu.com, simon.horman@netronome.com, alex.aring@gmail.com To: Jamal Hadi Salim Return-path: Received: from mail-wm0-f65.google.com ([74.125.82.65]:35443 "EHLO mail-wm0-f65.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750980AbdGYLey (ORCPT ); Tue, 25 Jul 2017 07:34:54 -0400 Received: by mail-wm0-f65.google.com with SMTP id r77so2792919wmd.2 for ; Tue, 25 Jul 2017 04:34:54 -0700 (PDT) Content-Disposition: inline In-Reply-To: Sender: netdev-owner@vger.kernel.org List-ID: Tue, Jul 25, 2017 at 01:27:03PM CEST, jhs@mojatatu.com wrote: >On 17-07-24 07:34 AM, Jiri Pirko wrote: >> Mon, Jul 24, 2017 at 03:35:46AM CEST, jhs@mojatatu.com wrote: >> > From: Jamal Hadi Salim > >> >> > @@ -128,6 +129,11 @@ static int tcf_dump_walker(struct tcf_hashinfo *hinfo, struct sk_buff *skb, >> > if (index < s_i) >> > continue; >> > >> > + if (jiffy_since && >> > + time_after(jiffy_since, >> > + (unsigned long)p->tcfa_tm.lastuse)) >> >> You don't need to check jiffy_since==0. Also, nicer ^^ this with a space :) >> > >Assuming that time_after() would work fine for jiffy_since being zero, >but: >wouldnt it be more efficient to just not call time_after() altogether? time_after is pretty trivial. But your call. > >> Other than this, looks fine. > >Ok, please no more changes - I am exhausted ;-> So speak for this >update or send patches afterwards if you dont like something. > >cheers, >jamal >