From: Stephen Hemminger <stephen@networkplumber.org>
To: kys@microsoft.com, haiyangz@microsoft.com, sthemmin@microsoft.com
Cc: devel@linuxdriverproject.org, netdev@vger.kernel.org
Subject: Re: [PATCH net-next 3/5] netvsc: optimize receive completions
Date: Tue, 25 Jul 2017 14:07:57 -0700 [thread overview]
Message-ID: <20170725140757.5c38ccc0@xeon-e3> (raw)
In-Reply-To: <20170725200422.13795-4-sthemmin@microsoft.com>
On Tue, 25 Jul 2017 13:04:20 -0700
Stephen Hemminger <stephen@networkplumber.org> wrote:
> Optimize how receive completion ring are managed.
> * Allocate only as many slots as needed for all buffers from host
> * Allocate before setting up sub channel for better error detection
> * Don't need to keep copy of initial receive section message
> * Only needt keep the transaction id, status doesn't matter
> * Precompute the watermark for when receive flushing is needed
> * Replace division with conditional test
> * Replace atomic per-device variable with per-channel check.
> * Handle corner case where receive completion send
> fails if ring buffer to host is full.
>
> Signed-off-by: Stephen Hemminger <sthemmin@microsoft.com>
I probably pushed the shrinkage too far for now. Hiayang raised the
point that probably need to keep the status value. I dropped storing
it since it was always SUCCESS unless the host sent a bad packet,
or the system was out of skb's.
Will send V2 that keeps the status value for now.
next prev parent reply other threads:[~2017-07-25 21:08 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-07-25 20:04 [PATCH net-next 0/5] netvsc: fixes and performance related changes Stephen Hemminger
2017-07-25 20:04 ` [PATCH net-next 1/5] netvsc: fix return value for set_channels Stephen Hemminger
2017-07-25 20:04 ` [PATCH net-next 2/5] netvsc: fix warnings reported by lockdep Stephen Hemminger
2017-07-25 20:04 ` [PATCH net-next 3/5] netvsc: optimize receive completions Stephen Hemminger
2017-07-25 21:07 ` Stephen Hemminger [this message]
2017-07-25 20:04 ` [PATCH net-next 4/5] netvsc: signal host if receive ring is emptied Stephen Hemminger
2017-07-25 20:04 ` [PATCH net-next 5/5] netvsc: allow smaller send/recv buffer size Stephen Hemminger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170725140757.5c38ccc0@xeon-e3 \
--to=stephen@networkplumber.org \
--cc=devel@linuxdriverproject.org \
--cc=haiyangz@microsoft.com \
--cc=kys@microsoft.com \
--cc=netdev@vger.kernel.org \
--cc=sthemmin@microsoft.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).