From: Shaohua Li <shli@kernel.org>
To: David Miller <davem@davemloft.net>
Cc: netdev@vger.kernel.org, Kernel-team@fb.com, shli@fb.com,
eric.dumazet@gmail.com, flo@fourcot.fr
Subject: Re: [PATCH V2 net] net: fix tcp reset packet flowlabel for ipv6
Date: Tue, 25 Jul 2017 14:35:06 -0700 [thread overview]
Message-ID: <20170725213506.jfnbinozo6mzyzpc@kernel.org> (raw)
In-Reply-To: <20170724.133455.562898067272108474.davem@davemloft.net>
On Mon, Jul 24, 2017 at 01:34:55PM -0700, David Miller wrote:
> From: Shaohua Li <shli@kernel.org>
> Date: Tue, 18 Jul 2017 12:03:37 -0700
>
> > + /* Since this is being sent on the wire obfuscate hash a bit
> > + * to minimize possbility that any useful information to an
> > + * attacker is leaked. Only lower 20 bits are relevant.
> > + */
> > + rol32(hash, 16);
>
> This doesn't help anything at all.
>
> I don't like things that try to give a sense of security (however
> little) but actually don't give any at all.
>
> I'd rather, therefore, that you remove this altogether.
ok, so you suggest removing the rol32() for ip6_make_flowlabel too, right? just
want to make sure.
Thanks,
Shaohua
prev parent reply other threads:[~2017-07-25 21:35 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-07-18 19:03 [PATCH V2 net] net: fix tcp reset packet flowlabel for ipv6 Shaohua Li
2017-07-24 20:34 ` David Miller
2017-07-24 23:12 ` Cong Wang
2017-07-25 21:32 ` Shaohua Li
2017-07-25 21:35 ` Shaohua Li [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170725213506.jfnbinozo6mzyzpc@kernel.org \
--to=shli@kernel.org \
--cc=Kernel-team@fb.com \
--cc=davem@davemloft.net \
--cc=eric.dumazet@gmail.com \
--cc=flo@fourcot.fr \
--cc=netdev@vger.kernel.org \
--cc=shli@fb.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox