From: Stephen Hemminger <stephen@networkplumber.org>
To: Arkadi Sharshevsky <arkadis@mellanox.com>
Cc: netdev@vger.kernel.org, davem@davemloft.net,
nikolay@cumulusnetworks.com, vivien.didelot@savoirfairelinux.com,
mlxsw@mellanox.com
Subject: Re: [PATCH iproute2] bridge: Assume master at FDB modification
Date: Wed, 26 Jul 2017 09:08:20 -0700 [thread overview]
Message-ID: <20170726090820.0252da7e@xeon-e3> (raw)
In-Reply-To: <1501083394-26180-1-git-send-email-arkadis@mellanox.com>
On Wed, 26 Jul 2017 18:36:34 +0300
Arkadi Sharshevsky <arkadis@mellanox.com> wrote:
> According to the man page the master flag should be the default, yet, the
> current code assumes otherwise.
>
> Signed-off-by: Arkadi Sharshevsky <arkadis@mellanox.com>
Agree that the documentation and code don't match.
But your change could break users with existing scripts by changing behavior.
It would be safer to change the man page not the code.
next prev parent reply other threads:[~2017-07-26 16:08 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-07-26 15:36 [PATCH iproute2] bridge: Assume master at FDB modification Arkadi Sharshevsky
2017-07-26 16:08 ` Stephen Hemminger [this message]
2017-07-26 16:21 ` Arkadi Sharshevsky
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170726090820.0252da7e@xeon-e3 \
--to=stephen@networkplumber.org \
--cc=arkadis@mellanox.com \
--cc=davem@davemloft.net \
--cc=mlxsw@mellanox.com \
--cc=netdev@vger.kernel.org \
--cc=nikolay@cumulusnetworks.com \
--cc=vivien.didelot@savoirfairelinux.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).