* [PATCH net] dccp: fix a memleak that dccp_ipv4 doesn't put reqsk properly
@ 2017-07-26 6:19 Xin Long
2017-07-27 7:01 ` David Miller
0 siblings, 1 reply; 2+ messages in thread
From: Xin Long @ 2017-07-26 6:19 UTC (permalink / raw)
To: network dev; +Cc: davem
The patch "dccp: fix a memleak that dccp_ipv6 doesn't put reqsk
properly" fixed reqsk refcnt leak for dccp_ipv6. The same issue
exists on dccp_ipv4.
This patch is to fix it for dccp_ipv4.
Signed-off-by: Xin Long <lucien.xin@gmail.com>
---
net/dccp/ipv4.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/net/dccp/ipv4.c b/net/dccp/ipv4.c
index f85d901..1b202f1 100644
--- a/net/dccp/ipv4.c
+++ b/net/dccp/ipv4.c
@@ -631,6 +631,7 @@ int dccp_v4_conn_request(struct sock *sk, struct sk_buff *skb)
goto drop_and_free;
inet_csk_reqsk_queue_hash_add(sk, req, DCCP_TIMEOUT_INIT);
+ reqsk_put(req);
return 0;
drop_and_free:
--
2.1.0
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH net] dccp: fix a memleak that dccp_ipv4 doesn't put reqsk properly
2017-07-26 6:19 [PATCH net] dccp: fix a memleak that dccp_ipv4 doesn't put reqsk properly Xin Long
@ 2017-07-27 7:01 ` David Miller
0 siblings, 0 replies; 2+ messages in thread
From: David Miller @ 2017-07-27 7:01 UTC (permalink / raw)
To: lucien.xin; +Cc: netdev
From: Xin Long <lucien.xin@gmail.com>
Date: Wed, 26 Jul 2017 14:19:46 +0800
> The patch "dccp: fix a memleak that dccp_ipv6 doesn't put reqsk
> properly" fixed reqsk refcnt leak for dccp_ipv6. The same issue
> exists on dccp_ipv4.
>
> This patch is to fix it for dccp_ipv4.
>
> Signed-off-by: Xin Long <lucien.xin@gmail.com>
Applied and queued up for -stable.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2017-07-27 7:01 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2017-07-26 6:19 [PATCH net] dccp: fix a memleak that dccp_ipv4 doesn't put reqsk properly Xin Long
2017-07-27 7:01 ` David Miller
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).