Re: [PATCH net-next 10/18] net: mvpp2: use the GoP interrupt for link status changes

Antoine Tenart
2017-07-26T00:10:09Z

[-- Attachment #1: Type: text/plain, Size: 734 bytes --]

Hi Thomas,

On Tue, Jul 25, 2017 at 03:17:48PM +0200, Thomas Petazzoni wrote:
> On Mon, 24 Jul 2017 15:48:40 +0200, Antoine Tenart wrote:
> > +
> > + port->link_irq = of_irq_get_byname(port_node, "link");
> > + if (port->link_irq == -EPROBE_DEFER) {
> > + err = -EPROBE_DEFER;
> > + goto err_free_irq;
> > + }
> > + if (port->link_irq <= 0)
> > + /* the link irq is optional */
> > + port->link_irq = 0;
>
> You need to add the irq_dispose_mapping() call corresponding to this
> of_irq_get_by_name() in the error path and in the remove path.

That's right. I'll fix that in v2.

Thanks!
Antoine

--
Antoine Ténart, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]