Re: [PATCH net-next 03/18] net: mvpp2: set the SMI PHY address when connecting to the PHY

Andrew Lunn
2017-07-28T04:22:05Z

On Thu, Jul 27, 2017 at 06:49:05PM -0700, Antoine Tenart wrote:
> Hi Andrew,
>
> On Wed, Jul 26, 2017 at 06:08:06PM +0200, Andrew Lunn wrote:
> > On Mon, Jul 24, 2017 at 03:48:33PM +0200, Antoine Tenart wrote:
> > >
> > > + if (priv->hw_version != MVPP22)
> > > + return 0;
> > > +
> > > + /* Set the SMI PHY address */
> > > + if (of_property_read_u32(port->phy_node, "reg", &phy_addr)) {
> > > + netdev_err(port->dev, "cannot find the PHY address\n");
> > > + return -EINVAL;
> > > + }
> > > +
> > > + writel(phy_addr, priv->iface_base + MVPP22_SMI_PHY_ADDR(port->gop_id));
> > > return 0;
> > > }
> >
> > You could use phy_dev->mdiodev->addr, rather than parse the DT.
>
> OK.
>
> > Why does the MAC need to know this address? The phylib and PHY driver
> > should be the only thing accessing the PHY, otherwise you are asking
> > for trouble.
>
> This is part of the SMI/xSMI interface. I added into the mvpp2 driver
> and not in the mvmdio one because the GoP port number must be known to
> set this register (so that would be even less clean to do it).

Hi Antoine

It is still not clear to my why you need to program the address into
the hardware. Is the hardware talking to the PHY?

Andrew