Re: [PATCH net-next 09/18] net: mvpp2: use named interrupts

Antoine Tenart
2017-07-25T10:41:28Z

[-- Attachment #1: Type: text/plain, Size: 919 bytes --]

Hi Sergei,

On Mon, Jul 24, 2017 at 07:49:03PM +0300, Sergei Shtylyov wrote:
> On 07/24/2017 04:48 PM, Antoine Tenart wrote:
> > + if (of_get_property(port_node, "interrupt-names", NULL)) {
> > + port->irq = of_irq_get_byname(port_node, "rx-shared");
> > + if (port->irq <= 0) {
> > + err = (port->irq == -EPROBE_DEFER) ?
> > + -EPROBE_DEFER : -EINVAL;
>
> Perhaps better:
>
> err = port->irq ?: -EINVAL;

Sure.

> > + goto err_free_netdev;
> > + }
> > + } else {
> > + /* kept for dt compatibility */
> > + port->irq = irq_of_parse_and_map(port_node, 0);
> > + if (port->irq <= 0) {
>
> Note that irq_of_parse_and_map() returns *unsigned int*, so negative
> error codes are not possible, 0 indicates bad IRQ.

That right, I'll fix that!

Thanks,
Antoine

--
Antoine Ténart, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]