Re: [PATCH net-next 03/18] net: mvpp2: set the SMI PHY address when connecting to the PHY

Antoine Tenart
2017-07-25T10:41:26Z

[-- Attachment #1: Type: text/plain, Size: 543 bytes --]

Hi Sergei,

On Mon, Jul 24, 2017 at 07:40:01PM +0300, Sergei Shtylyov wrote:
> On 07/24/2017 04:48 PM, Antoine Tenart wrote:
>
> > + /* Set the SMI PHY address */
> > + if (of_property_read_u32(port->phy_node, "reg", &phy_addr)) {
> > + netdev_err(port->dev, "cannot find the PHY address\n");
> > + return -EINVAL;
>
> Wny not propagte the error from of_property_read_u32()?

I could do this, you're right.

Antoine

--
Antoine Ténart, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]