netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Stephen Hemminger <stephen@networkplumber.org>
To: kys@microsoft.com, haiyangz@microsoft.com, sthemmin@microsoft.com
Cc: devel@linuxdriverproject.org, netdev@vger.kernel.org
Subject: [PATCH net-next v3 7/7] netvsc: signal host if receive ring is emptied
Date: Fri, 28 Jul 2017 08:59:47 -0700	[thread overview]
Message-ID: <20170728155947.10062-8-sthemmin@microsoft.com> (raw)
In-Reply-To: <20170728155947.10062-1-sthemmin@microsoft.com>

Latency improvement related to NAPI conversion.
If all packets are processed from receive ring then need
to signal host.

Signed-off-by: Stephen Hemminger <sthemmin@microsoft.com>
---
 drivers/net/hyperv/netvsc.c | 11 ++++++++---
 1 file changed, 8 insertions(+), 3 deletions(-)

diff --git a/drivers/net/hyperv/netvsc.c b/drivers/net/hyperv/netvsc.c
index db95487807fd..c64934c64dca 100644
--- a/drivers/net/hyperv/netvsc.c
+++ b/drivers/net/hyperv/netvsc.c
@@ -1195,10 +1195,15 @@ int netvsc_poll(struct napi_struct *napi, int budget)
 		nvchan->desc = hv_pkt_iter_next(channel, nvchan->desc);
 	}
 
-	/* If send of  pending receive completions suceeded
-	 *   and did not exhaust NAPI budget
+	/* if ring is empty, signal host */
+	if (!nvchan->desc)
+		hv_pkt_iter_close(channel);
+
+	/* If send of pending receive completions suceeded
+	 *   and did not exhaust NAPI budget this time
 	 *   and not doing busy poll
-	 * then reschedule if more data has arrived from host
+	 * then re-enable host interrupts
+	 *     and reschedule if ring is not empty.
 	 */
 	if (send_recv_completions(nvchan) == 0 &&
 	    work_done < budget &&
-- 
2.11.0

  parent reply	other threads:[~2017-07-28 15:59 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-07-28 15:59 [PATCH net-next v3 0/7] netvsc: minor fixes and optimization Stephen Hemminger
2017-07-28 15:59 ` [PATCH net-next v3 1/7] netvsc: fix return value for set_channels Stephen Hemminger
2017-07-28 15:59 ` [PATCH net-next v3 2/7] netvsc: fix warnings reported by lockdep Stephen Hemminger
2017-08-24  8:36   ` David Woodhouse
2017-08-24 22:50     ` Stephen Hemminger
2017-07-28 15:59 ` [PATCH net-next v3 3/7] netvsc: don't print pointer value in error message Stephen Hemminger
2017-07-28 15:59 ` [PATCH net-next v3 4/7] netvsc: remove unnecessary indirection of page_buffer Stephen Hemminger
2017-07-28 15:59 ` [PATCH net-next v3 5/7] netvsc: optimize receive completions Stephen Hemminger
2017-07-28 15:59 ` [PATCH net-next v3 6/7] netvsc: fix error unwind on device setup failure Stephen Hemminger
2017-07-28 15:59 ` Stephen Hemminger [this message]
2017-07-29 22:26 ` [PATCH net-next v3 0/7] netvsc: minor fixes and optimization David Miller

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170728155947.10062-8-sthemmin@microsoft.com \
    --to=stephen@networkplumber.org \
    --cc=devel@linuxdriverproject.org \
    --cc=haiyangz@microsoft.com \
    --cc=kys@microsoft.com \
    --cc=netdev@vger.kernel.org \
    --cc=sthemmin@microsoft.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).