Re: [PATCH V5 net-next 7/8] net: hns3: Add Ethtool support to HNS3 driver

[Andrew Lunn <andrew@lunn.ch>]

On Fri, Jul 28, 2017 at 11:26:51PM +0100, Salil Mehta wrote:
> +static const struct hns3_link_mode_mapping hns3_lm_map[] = {
> +	{HNS3_LM_FIBRE_BIT, ETHTOOL_LINK_MODE_FIBRE_BIT, FLG},
> +	{HNS3_LM_AUTONEG_BIT, ETHTOOL_LINK_MODE_Autoneg_BIT, FLG},
> +	{HNS3_LM_TP_BIT, ETHTOOL_LINK_MODE_TP_BIT, FLG},
> +	{HNS3_LM_PAUSE_BIT, ETHTOOL_LINK_MODE_Pause_BIT, FLG},
> +	{HNS3_LM_BACKPLANE_BIT, ETHTOOL_LINK_MODE_Backplane_BIT, FLG},
> +	{HNS3_LM_10BASET_HALF_BIT, ETHTOOL_LINK_MODE_10baseT_Half_BIT, FLG},
> +	{HNS3_LM_10BASET_FULL_BIT, ETHTOOL_LINK_MODE_10baseT_Full_BIT, FLG},
> +	{HNS3_LM_100BASET_HALF_BIT, ETHTOOL_LINK_MODE_100baseT_Half_BIT, FLG},
> +	{HNS3_LM_100BASET_FULL_BIT, ETHTOOL_LINK_MODE_100baseT_Full_BIT, FLG},
> +	{HNS3_LM_1000BASET_FULL_BIT, ETHTOOL_LINK_MODE_1000baseT_Full_BIT, FLG},
> +};

It seems like all entries have link_mode_ksettings set to FLG. Which
probably indicates it is pointless.

> +
> +static inline void hns3_driv_to_eth_caps(u32 caps,
> +					 struct ethtool_link_ksettings *cmd)

Please don't use inline anywhere except in header file stub
functions. Let the compiler decide.

> +static int hns3_get_link_ksettings(struct net_device *netdev,
> +				   struct ethtool_link_ksettings *cmd)
> +{
> +	struct hns3_nic_priv *priv = netdev_priv(netdev);
> +	struct hnae3_handle *h = priv->ae_handle;
> +	u32 supported_caps;
> +	u32 advertised_caps;
> +	u8 media_type;
> +	u8 link_stat;
> +	u8 auto_neg;
> +	u8 duplex;
> +	u32 speed;
> +
> +	if (!h->ae_algo || !h->ae_algo->ops)
> +		return -ESRCH;

#define	ESRCH	 3	/* No such process */

No such process ????

   Andrew