From: Stephen Hemminger <stephen@networkplumber.org>
To: Natale Patriciello <natale.patriciello@gmail.com>
Cc: "David S . Miller" <davem@davemloft.net>,
Alexey Kuznetsov <kuznet@ms2.inr.ac.ru>,
James Morris <jmorris@namei.org>,
Hideaki YOSHIFUJI <yoshfuji@linux-ipv6.org>,
Patrick McHardy <kaber@trash.net>,
netdev <netdev@vger.kernel.org>,
Ahmed Said <ahmed.said@uniroma2.it>,
Francesco Zampognaro <zampognaro@ing.uniroma2.it>,
Cesare Roseti <roseti@ing.uniroma2.it>
Subject: Re: [RFC PATCH v1 5/5] wave: Added basic version of TCP Wave
Date: Sat, 29 Jul 2017 08:32:34 -0700 [thread overview]
Message-ID: <20170729083234.57f58ab5@xeon-e3> (raw)
In-Reply-To: <20170728195919.10099-6-natale.patriciello@gmail.com>
On Fri, 28 Jul 2017 21:59:19 +0200
Natale Patriciello <natale.patriciello@gmail.com> wrote:
> +
> +#define WAVE_DEBUG 1
> +
> +#ifdef WAVE_DEBUG
> + #define DBG(msg ...) printk(KERN_DEBUG "WAVE_DEBUG: " msg)
> +#else
> + static inline void DBG(const char *msg, ...) { }
> +#endif
> +
Don't reinvent your own debug macros.
Use standard pr_debug instead.
+
+ if (ca->history != 0)
+ kfree(ca->history);
First, off the comparison should be with NULL not 0.
Secondly, kfree already does the right thing with kfree(NULL).
+ /* Usually the burst end is also reflected in the rs->delivered
+ * variable. If this is not the case, and such variable is
+ * behind just for 1 segment, then do this experimental thing
+ * to re-allineate the burst with the rs->delivered variable.
+ * In the majority of cases, we went out of allineation because
+ * of a tail loss probe. */
Put the last */ in column with other parts of block.
* of a tail loss probe.
*/
next prev parent reply other threads:[~2017-07-29 15:32 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-07-28 19:59 [RFC PATCH v1 0/5] TCP Wave Natale Patriciello
2017-07-28 19:59 ` [RFC PATCH v1 1/5] tcp: Added callback for timed sender operations Natale Patriciello
2017-07-28 19:59 ` [RFC PATCH v1 2/5] tcp: Implemented the timing-based operations Natale Patriciello
2017-07-29 1:46 ` David Miller
2017-07-28 19:59 ` [RFC PATCH v1 3/5] tcp: PSH frames sent without timer involved Natale Patriciello
2017-07-28 19:59 ` [RFC PATCH v1 4/5] tcp: Add initial delay to allow data queueing Natale Patriciello
2017-07-28 19:59 ` [RFC PATCH v1 5/5] wave: Added basic version of TCP Wave Natale Patriciello
2017-07-28 23:15 ` Neal Cardwell
2017-07-29 1:51 ` David Miller
2017-07-29 1:52 ` David Miller
2017-07-29 15:32 ` Stephen Hemminger [this message]
2017-07-31 13:39 ` David Laight
2017-07-29 5:33 ` [RFC PATCH v1 0/5] " Eric Dumazet
2017-09-02 20:33 ` Natale Patriciello
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170729083234.57f58ab5@xeon-e3 \
--to=stephen@networkplumber.org \
--cc=ahmed.said@uniroma2.it \
--cc=davem@davemloft.net \
--cc=jmorris@namei.org \
--cc=kaber@trash.net \
--cc=kuznet@ms2.inr.ac.ru \
--cc=natale.patriciello@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=roseti@ing.uniroma2.it \
--cc=yoshfuji@linux-ipv6.org \
--cc=zampognaro@ing.uniroma2.it \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).