* [PATCH] mv643xx_eth: fix of_irq_to_resource() error check
@ 2017-07-29 19:18 Sergei Shtylyov
2017-08-01 0:57 ` David Miller
0 siblings, 1 reply; 2+ messages in thread
From: Sergei Shtylyov @ 2017-07-29 19:18 UTC (permalink / raw)
To: Sebastian Hesselbarth, netdev; +Cc: Thomas Petazzoni, Sergei Shtylyov
[-- Attachment #1: mv643xx_eth-fix-of_irq_to_resource-error-check.patch --]
[-- Type: text/plain, Size: 1023 bytes --]
of_irq_to_resource() has recently been fixed to return negative error #'s
along with 0 in case of failure, however the Marvell MV643xx Ethernet
driver still only regards 0 as invalid IRQ -- fix it up.
Fixes: 7a4228bbff76 ("of: irq: use of_irq_get() in of_irq_to_resource()")
Signed-off-by: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
---
The patch is against DaveM's 'net.git' repo.
drivers/net/ethernet/marvell/mv643xx_eth.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
Index: net/drivers/net/ethernet/marvell/mv643xx_eth.c
===================================================================
--- net.orig/drivers/net/ethernet/marvell/mv643xx_eth.c
+++ net/drivers/net/ethernet/marvell/mv643xx_eth.c
@@ -2734,7 +2734,7 @@ static int mv643xx_eth_shared_of_add_por
ppd.shared = pdev;
memset(&res, 0, sizeof(res));
- if (!of_irq_to_resource(pnp, 0, &res)) {
+ if (of_irq_to_resource(pnp, 0, &res) <= 0) {
dev_err(&pdev->dev, "missing interrupt on %s\n", pnp->name);
return -EINVAL;
}
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH] mv643xx_eth: fix of_irq_to_resource() error check
2017-07-29 19:18 [PATCH] mv643xx_eth: fix of_irq_to_resource() error check Sergei Shtylyov
@ 2017-08-01 0:57 ` David Miller
0 siblings, 0 replies; 2+ messages in thread
From: David Miller @ 2017-08-01 0:57 UTC (permalink / raw)
To: sergei.shtylyov; +Cc: sebastian.hesselbarth, netdev, thomas.petazzoni
From: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
Date: Sat, 29 Jul 2017 22:18:41 +0300
> of_irq_to_resource() has recently been fixed to return negative error #'s
> along with 0 in case of failure, however the Marvell MV643xx Ethernet
> driver still only regards 0 as invalid IRQ -- fix it up.
>
> Fixes: 7a4228bbff76 ("of: irq: use of_irq_get() in of_irq_to_resource()")
> Signed-off-by: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
Applied.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2017-08-01 0:57 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2017-07-29 19:18 [PATCH] mv643xx_eth: fix of_irq_to_resource() error check Sergei Shtylyov
2017-08-01 0:57 ` David Miller
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).