From: Andrew Lunn <andrew@lunn.ch>
To: "Niklas Söderlund" <niklas.soderlund+renesas@ragnatech.se>
Cc: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>,
Geert Uytterhoeven <geert@linux-m68k.org>,
netdev@vger.kernel.org, linux-renesas-soc@vger.kernel.org
Subject: Re: [PATCH v2] ravb: add wake-on-lan support via magic packet
Date: Sun, 30 Jul 2017 19:07:38 +0200 [thread overview]
Message-ID: <20170730170738.GA29373@lunn.ch> (raw)
In-Reply-To: <20170730140646.11781-1-niklas.soderlund+renesas@ragnatech.se>
Hi Niklas
> @@ -2041,6 +2073,11 @@ static int ravb_probe(struct platform_device *pdev)
>
> priv->chip_id = chip_id;
>
> + /* Get clock, if not found that's OK but Wake-On-Lan is unavailable */
> + priv->clk = devm_clk_get(&pdev->dev, NULL);
> + if (IS_ERR(priv->clk))
> + priv->clk = NULL;
Can you get EPROBE_DEFER returned?
Andrew
next prev parent reply other threads:[~2017-07-30 17:07 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-07-30 14:06 [PATCH v2] ravb: add wake-on-lan support via magic packet Niklas Söderlund
2017-07-30 17:07 ` Andrew Lunn [this message]
2017-07-30 19:51 ` Niklas Söderlund
2017-07-30 20:07 ` Andrew Lunn
2017-07-30 20:19 ` Niklas Söderlund
2017-08-14 10:24 ` Geert Uytterhoeven
2017-07-31 19:47 ` Sergei Shtylyov
2017-08-01 10:13 ` Niklas Söderlund
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170730170738.GA29373@lunn.ch \
--to=andrew@lunn.ch \
--cc=geert@linux-m68k.org \
--cc=linux-renesas-soc@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=niklas.soderlund+renesas@ragnatech.se \
--cc=sergei.shtylyov@cogentembedded.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).