From mboxrd@z Thu Jan 1 00:00:00 1970 From: Andrew Lunn Subject: Re: [PATCH net-next] net: fec: Allow reception of frames bigger than 1522 bytes Date: Mon, 31 Jul 2017 04:27:26 +0200 Message-ID: <20170731022726.GA30155@lunn.ch> References: <1501436165-20259-1-git-send-email-andrew@lunn.ch> <20170730.192629.124814765201077334.davem@davemloft.net> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: netdev@vger.kernel.org, fugang.duan@nxp.com To: David Miller Return-path: Received: from vps0.lunn.ch ([178.209.37.122]:45352 "EHLO vps0.lunn.ch" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751760AbdGaC13 (ORCPT ); Sun, 30 Jul 2017 22:27:29 -0400 Content-Disposition: inline In-Reply-To: <20170730.192629.124814765201077334.davem@davemloft.net> Sender: netdev-owner@vger.kernel.org List-ID: On Sun, Jul 30, 2017 at 07:26:29PM -0700, David Miller wrote: > From: Andrew Lunn > Date: Sun, 30 Jul 2017 19:36:05 +0200 > > > The FEC Receive Control Register has a 14 bit field indicating the > > longest frame that my be received. It is being set to 1522. Frames > > longer than this are discarded, but counted as being in error. > > > > When using DSA, frames from the switch has an additional header, > > either 4 or 8 bytes if a Marvell switch is used. Thus a full MTU frame > > of 1522 bytes received by the switch on a port becomes 1530 bytes when > > passed to the host via the FEC interface. > > > > Change the maximum receive size to 2048 - 64, where 64 is the maximum > > rx_alignment applied on the receive buffer for AVB capable FEC > > cores. Use this value also for the maximum receive buffer size. The > > driver is already allocating a receive SKB of 2048 bytes, so this > > change should not have any significant effects. > > > > Tested on imx51, imx6, vf610. > > > > Signed-off-by: Andrew Lunn > > Applied with commit log message typo fixed. Hi David Thanks for fixing the typo. Andrew