From: Andrew Lunn <andrew@lunn.ch>
To: Egil Hjelmeland <privat@egil-hjelmeland.no>
Cc: vivien.didelot@savoirfairelinux.com, f.fainelli@gmail.com,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
kernel@pengutronix.de
Subject: Re: [PATCH net-next 0/2] Refactor lan9303_xxx_packet_processing
Date: Mon, 31 Jul 2017 15:22:36 +0200 [thread overview]
Message-ID: <20170731132236.GB24562@lunn.ch> (raw)
In-Reply-To: <20170731113355.4284-1-privat@egil-hjelmeland.no>
On Mon, Jul 31, 2017 at 01:33:53PM +0200, Egil Hjelmeland wrote:
> First patch:
> Change lan9303_enable_packet_processing,
> lan9303_disable_packet_processing():
> Pass port number (0,1,2) as parameter instead of port offset.
> Plus replaced a constant 0x400 with LAN9303_SWITCH_PORT_REG()
Hi Egil
The cover note and the commit message should concentrate on the Why,
not the What. I can see the What by reading the patch.
Why do you want to pass port numbers?
Note that for netdev, the cover note also ends up in git as part of
the history.
Andrew
next prev parent reply other threads:[~2017-07-31 13:22 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-07-31 11:33 [PATCH net-next 0/2] Refactor lan9303_xxx_packet_processing Egil Hjelmeland
2017-07-31 11:33 ` [PATCH net-next 1/2] net: dsa: lan9303: Refactor lan9303_xxx_packet_processing() Egil Hjelmeland
2017-07-31 13:36 ` Andrew Lunn
2017-07-31 11:33 ` [PATCH net-next 2/2] net: dsa: lan9303: Simplify lan9303_xxx_packet_processing() usage Egil Hjelmeland
2017-07-31 13:46 ` Andrew Lunn
2017-07-31 14:09 ` Egil Hjelmeland
2017-07-31 14:47 ` Andrew Lunn
2017-07-31 14:00 ` Vivien Didelot
2017-07-31 14:32 ` Egil Hjelmeland
2017-07-31 14:43 ` Vivien Didelot
2017-07-31 14:58 ` Egil Hjelmeland
2017-07-31 15:01 ` Vivien Didelot
2017-07-31 15:08 ` Egil Hjelmeland
2017-07-31 15:15 ` Vivien Didelot
2017-07-31 13:22 ` Andrew Lunn [this message]
2017-07-31 13:32 ` [PATCH net-next 0/2] Refactor lan9303_xxx_packet_processing Egil Hjelmeland
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170731132236.GB24562@lunn.ch \
--to=andrew@lunn.ch \
--cc=f.fainelli@gmail.com \
--cc=kernel@pengutronix.de \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=privat@egil-hjelmeland.no \
--cc=vivien.didelot@savoirfairelinux.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox