From: David Miller <davem@davemloft.net>
To: mohamed.asnd@gmail.com
Cc: netdev@vger.kernel.org, torvalds@linux-foundation.org,
linux-kernel@vger.kernel.org, mohamed.a.alrshah@ieee.org
Subject: Re: [PATCH] Adding Agile-SD TCP module and modifying Kconfig and Makefile
Date: Tue, 01 Aug 2017 22:47:26 -0700 (PDT) [thread overview]
Message-ID: <20170801.224726.2084508191542326424.davem@davemloft.net> (raw)
In-Reply-To: <20170802043701.13507-1-mohamed.asnd@gmail.com>
From: mohamedalrshah <mohamed.asnd@gmail.com>
Date: Wed, 2 Aug 2017 12:37:01 +0800
> +//#define NS_PROTOCOL "tcp_agilesd.c"
> +//#include "../ns-linux-c.h"
> +//#include "../ns-linux-util.h"
> +//#include <math.h>
There is no way this submission will be considered seriously with all of
this cruft in it.
Your new module needs significant cleanups.
next prev parent reply other threads:[~2017-08-02 5:47 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <stephen@networkplumber.org>
2017-08-02 4:37 ` [PATCH] Adding Agile-SD TCP module and modifying Kconfig and Makefile mohamedalrshah
2017-08-02 5:47 ` David Miller [this message]
2017-08-02 4:43 ` mohamedalrshah
2017-08-02 14:09 ` David Laight
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170801.224726.2084508191542326424.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=linux-kernel@vger.kernel.org \
--cc=mohamed.a.alrshah@ieee.org \
--cc=mohamed.asnd@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).