* [PATCH net-next] net: bcmgenet: Add dependency on HAS_IOMEM && OF
@ 2017-08-01 0:53 Florian Fainelli
2017-08-01 0:54 ` David Miller
0 siblings, 1 reply; 2+ messages in thread
From: Florian Fainelli @ 2017-08-01 0:53 UTC (permalink / raw)
To: netdev; +Cc: davem, opendmb, jaedon.shin, Florian Fainelli
The driver needs CONFIG_HAS_IOMEM and OF to be functional, but we still
let it build with COMPILE_TEST. This fixes the unmet dependency after
selecting MDIO_BCM_UNIMAC in commit mentioned below:
warning: (NET_DSA_BCM_SF2 && BCMGENET) selects MDIO_BCM_UNIMAC which has
unmet direct dependencies (NETDEVICES && MDIO_DEVICE && HAS_IOMEM &&
OF_MDIO)
Fixes: 9a4e79697009 ("net: bcmgenet: utilize generic Broadcom UniMAC MDIO controller driver")
Signed-off-by: Florian Fainelli <f.fainelli@gmail.com>
---
drivers/net/ethernet/broadcom/Kconfig | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/net/ethernet/broadcom/Kconfig b/drivers/net/ethernet/broadcom/Kconfig
index ec7a798c6bd1..45775399cab6 100644
--- a/drivers/net/ethernet/broadcom/Kconfig
+++ b/drivers/net/ethernet/broadcom/Kconfig
@@ -61,6 +61,7 @@ config BCM63XX_ENET
config BCMGENET
tristate "Broadcom GENET internal MAC support"
+ depends on (OF && HAS_IOMEM) || COMPILE_TEST
select MII
select PHYLIB
select FIXED_PHY
--
2.9.3
^ permalink raw reply related [flat|nested] 2+ messages in thread* Re: [PATCH net-next] net: bcmgenet: Add dependency on HAS_IOMEM && OF
2017-08-01 0:53 [PATCH net-next] net: bcmgenet: Add dependency on HAS_IOMEM && OF Florian Fainelli
@ 2017-08-01 0:54 ` David Miller
0 siblings, 0 replies; 2+ messages in thread
From: David Miller @ 2017-08-01 0:54 UTC (permalink / raw)
To: f.fainelli; +Cc: netdev, opendmb, jaedon.shin
From: Florian Fainelli <f.fainelli@gmail.com>
Date: Mon, 31 Jul 2017 17:53:07 -0700
> The driver needs CONFIG_HAS_IOMEM and OF to be functional, but we still
> let it build with COMPILE_TEST. This fixes the unmet dependency after
> selecting MDIO_BCM_UNIMAC in commit mentioned below:
>
> warning: (NET_DSA_BCM_SF2 && BCMGENET) selects MDIO_BCM_UNIMAC which has
> unmet direct dependencies (NETDEVICES && MDIO_DEVICE && HAS_IOMEM &&
> OF_MDIO)
>
> Fixes: 9a4e79697009 ("net: bcmgenet: utilize generic Broadcom UniMAC MDIO controller driver")
> Signed-off-by: Florian Fainelli <f.fainelli@gmail.com>
Applied.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2017-08-01 0:54 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2017-08-01 0:53 [PATCH net-next] net: bcmgenet: Add dependency on HAS_IOMEM && OF Florian Fainelli
2017-08-01 0:54 ` David Miller
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).