From: Andrew Lunn <andrew@lunn.ch>
To: Florian Fainelli <f.fainelli@gmail.com>
Cc: Vivien Didelot <vivien.didelot@savoirfairelinux.com>,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
kernel@savoirfairelinux.com,
"David S. Miller" <davem@davemloft.net>
Subject: Re: [PATCH net-next 10/11] net: dsa: mv88e6xxx: remove EEE support
Date: Tue, 1 Aug 2017 19:27:57 +0200 [thread overview]
Message-ID: <20170801172757.GL23157@lunn.ch> (raw)
In-Reply-To: <17c26dee-c285-4dd5-1be0-286c0126d4db@gmail.com>
> If the MAC does not support EEE but the PHY does I think you can still
> allow EEE to be advertised and enabled, you just won't have the MAC be
> able to leverage the power savings that EEE brings. AFAICT this is still
> a valid mode whereby the PHY is put in a lower power mode, just not the
> whole transmit path (MAC + PHY).
Hi Florian
I read a couple of datasheets for a few phys doing EEE. Both said the
same, the MAC has to indicate to the PHY when low power should be
entered and existed. The PHY itself does not appear to do anything on
its own.
It would be good to read the standards about this. But i don't think
we should tell userspace EEE is enabled, if the PHY has it enabled,
but the MAC is not capable and hence EEE is not actually being used at
all.
Andrew
next prev parent reply other threads:[~2017-08-01 17:27 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-07-31 22:17 [PATCH net-next 00/11] net: dsa: rework EEE support Vivien Didelot
2017-07-31 22:17 ` [PATCH net-next 01/11] net: dsa: make EEE ops optional Vivien Didelot
2017-08-01 14:07 ` Andrew Lunn
2017-07-31 22:17 ` [PATCH net-next 02/11] net: dsa: qca8k: fix EEE init Vivien Didelot
2017-07-31 22:17 ` [PATCH net-next 03/11] net: dsa: qca8k: enable EEE once Vivien Didelot
2017-07-31 22:17 ` [PATCH net-next 04/11] net: dsa: qca8k: do not cache unneeded EEE fields Vivien Didelot
2017-07-31 22:17 ` [PATCH net-next 05/11] net: dsa: qca8k: remove qca8k_get_eee Vivien Didelot
2017-07-31 22:17 ` [PATCH net-next 06/11] net: dsa: bcm_sf2: remove unneeded supported flags Vivien Didelot
2017-07-31 22:17 ` [PATCH net-next 07/11] net: dsa: mv88e6xxx: call phy_init_eee Vivien Didelot
2017-07-31 22:17 ` [PATCH net-next 08/11] net: dsa: call phy_init_eee in DSA layer Vivien Didelot
2017-07-31 22:17 ` [PATCH net-next 09/11] net: dsa: remove PHY device argument from .set_eee Vivien Didelot
2017-07-31 22:17 ` [PATCH net-next 10/11] net: dsa: mv88e6xxx: remove EEE support Vivien Didelot
2017-08-01 14:28 ` Andrew Lunn
2017-08-01 15:36 ` Vivien Didelot
2017-08-01 16:06 ` Andrew Lunn
2017-08-01 16:33 ` Florian Fainelli
2017-08-01 17:27 ` Andrew Lunn [this message]
2017-08-01 18:53 ` Florian Fainelli
2017-08-01 16:34 ` Vivien Didelot
2017-08-01 20:08 ` Vivien Didelot
2017-07-31 22:17 ` [PATCH net-next 11/11] net: dsa: rename switch EEE ops Vivien Didelot
2017-08-01 14:31 ` [PATCH net-next 00/11] net: dsa: rework EEE support Andrew Lunn
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170801172757.GL23157@lunn.ch \
--to=andrew@lunn.ch \
--cc=davem@davemloft.net \
--cc=f.fainelli@gmail.com \
--cc=kernel@savoirfairelinux.com \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=vivien.didelot@savoirfairelinux.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).