* [PATCH 1/2] atm: adummy: constify attribute_group structure
@ 2017-08-01 23:57 Amitoj Kaur Chawla
2017-08-02 23:53 ` David Miller
0 siblings, 1 reply; 2+ messages in thread
From: Amitoj Kaur Chawla @ 2017-08-01 23:57 UTC (permalink / raw)
To: 3chas3, linux-atm-general, netdev, linux-kernel
Functions working with attribute_groups provided by <linux/sysfs.h>
work with const attribute_group. These attribute_group structures do not
change at runtime so mark them as const.
File size before:
text data bss dec hex filename
2033 1448 0 3481 d99 drivers/atm/adummy.o
File size after:
text data bss dec hex filename
2129 1352 0 3481 d99 drivers/atm/adummy.o
This change was made with the help of Coccinelle.
Signed-off-by: Amitoj Kaur Chawla <amitoj1606@gmail.com>
---
drivers/atm/adummy.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/atm/adummy.c b/drivers/atm/adummy.c
index 1fd25e8..da27ddf 100644
--- a/drivers/atm/adummy.c
+++ b/drivers/atm/adummy.c
@@ -71,7 +71,7 @@ static struct attribute *adummy_attrs[] = {
NULL
};
-static struct attribute_group adummy_group_attrs = {
+static const struct attribute_group adummy_group_attrs = {
.name = NULL, /* We want them in dev's root folder */
.attrs = adummy_attrs
};
--
2.7.4
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH 1/2] atm: adummy: constify attribute_group structure
2017-08-01 23:57 [PATCH 1/2] atm: adummy: constify attribute_group structure Amitoj Kaur Chawla
@ 2017-08-02 23:53 ` David Miller
0 siblings, 0 replies; 2+ messages in thread
From: David Miller @ 2017-08-02 23:53 UTC (permalink / raw)
To: amitoj1606; +Cc: 3chas3, linux-atm-general, netdev, linux-kernel
From: Amitoj Kaur Chawla <amitoj1606@gmail.com>
Date: Tue, 1 Aug 2017 19:57:38 -0400
> Functions working with attribute_groups provided by <linux/sysfs.h>
> work with const attribute_group. These attribute_group structures do not
> change at runtime so mark them as const.
>
> File size before:
> text data bss dec hex filename
> 2033 1448 0 3481 d99 drivers/atm/adummy.o
>
> File size after:
> text data bss dec hex filename
> 2129 1352 0 3481 d99 drivers/atm/adummy.o
>
> This change was made with the help of Coccinelle.
>
> Signed-off-by: Amitoj Kaur Chawla <amitoj1606@gmail.com>
Applied.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2017-08-02 23:53 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2017-08-01 23:57 [PATCH 1/2] atm: adummy: constify attribute_group structure Amitoj Kaur Chawla
2017-08-02 23:53 ` David Miller
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).