From: Andrew Lunn <andrew@lunn.ch>
To: Mason <slash.tmp@free.fr>
Cc: Mans Rullgard <mans@mansr.com>, netdev <netdev@vger.kernel.org>,
Florian Fainelli <f.fainelli@gmail.com>,
David Miller <davem@davemloft.net>,
Linux ARM <linux-arm-kernel@lists.infradead.org>
Subject: Re: [RFC PATCH v2 1/2] net: ethernet: nb8800: Reset HW block in ndo_open
Date: Wed, 2 Aug 2017 15:54:37 +0200 [thread overview]
Message-ID: <20170802135437.GA25781@lunn.ch> (raw)
In-Reply-To: <ef36cd4a-b1b5-7505-34d1-250c736d6731@free.fr>
> > Finally, you still haven't explained why the hw needs to be reset in
> > ndo_open(). Whatever is causing your lockup can almost certainly be
> > triggered in some other way too. I will not accept this side-stepping
> > of the issue.
>
> (I was not aware that you were the final authority on which
> patches are accepted upstream.)
./scripts/get_maintainer.pl -f drivers/net/ethernet/aurora/nb8800.c
"David S. Miller" <davem@davemloft.net> (commit_signer:6/6=100%)
Mans Rullgard <mans@mansr.com> (commit_signer:2/6=33%)
Jarod Wilson <jarod@redhat.com> (commit_signer:1/6=17%,authored:1/6=17%,removed_lines:1/17=6%)
Stephen Hemminger <stephen@networkplumber.org> (commit_signer:1/6=17%)
Florian Fainelli <f.fainelli@gmail.com> (commit_signer:1/6=17%,added_lines:1/14=7%,removed_lines:11/17=65%)
Javier Martinez Canillas <javier@osg.samsung.com> (authored:1/6=17%,added_lines:1/14=7%)
Johan Hovold <johan@kernel.org> (authored:1/6=17%,added_lines:7/14=50%,removed_lines:2/17=12%)
Johannes Berg <johannes.berg@intel.com> (authored:1/6=17%,added_lines:2/14=14%,removed_lines:2/17=12%)
Wei Yongjun <weiyongjun1@huawei.com> (authored:1/6=17%,added_lines:3/14=21%,removed_lines:1/17=6%)
David is very likely to listen to Mans's recommendations, since Mans
has done most of the review work for this driver.
Andrew
next prev parent reply other threads:[~2017-08-02 13:54 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-08-01 16:32 [RFC PATCH v2 0/2] nb8800 suspend/resume support Mason
2017-08-01 16:37 ` [RFC PATCH v2 1/2] net: ethernet: nb8800: Reset HW block in ndo_open Mason
2017-08-02 11:02 ` Måns Rullgård
2017-08-02 11:54 ` Mason
2017-08-02 13:54 ` Andrew Lunn [this message]
2017-08-02 14:33 ` Måns Rullgård
2017-08-01 16:43 ` [RFC PATCH v2 2/2] net: ethernet: nb8800: Add suspend/resume support Mason
2017-08-02 14:41 ` [RFC PATCH v2 0/2] nb8800 " Mason
2017-08-02 15:26 ` Mason
2017-08-02 15:36 ` Måns Rullgård
2017-08-02 15:52 ` Mason
2017-08-02 15:56 ` Måns Rullgård
2017-08-02 16:07 ` Mason
2017-08-02 16:10 ` Måns Rullgård
2017-08-02 16:19 ` David Laight
2017-08-02 16:39 ` Mason
2017-08-02 16:43 ` Måns Rullgård
2017-08-02 17:31 ` Mason
2017-08-02 20:02 ` Mason
2017-08-03 8:34 ` Mason
2017-08-03 12:19 ` Måns Rullgård
2017-08-03 12:18 ` Måns Rullgård
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170802135437.GA25781@lunn.ch \
--to=andrew@lunn.ch \
--cc=davem@davemloft.net \
--cc=f.fainelli@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=mans@mansr.com \
--cc=netdev@vger.kernel.org \
--cc=slash.tmp@free.fr \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).