From mboxrd@z Thu Jan 1 00:00:00 1970 From: Andrew Lunn Subject: Re: [RFC PATCH v2 1/2] net: ethernet: nb8800: Reset HW block in ndo_open Date: Wed, 2 Aug 2017 15:54:37 +0200 Message-ID: <20170802135437.GA25781@lunn.ch> References: <33d1ab47-6098-5e3f-8a3c-f72626d07113@free.fr> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: Mans Rullgard , netdev , Florian Fainelli , David Miller , Linux ARM To: Mason Return-path: Received: from vps0.lunn.ch ([178.209.37.122]:49173 "EHLO vps0.lunn.ch" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752036AbdHBNym (ORCPT ); Wed, 2 Aug 2017 09:54:42 -0400 Content-Disposition: inline In-Reply-To: Sender: netdev-owner@vger.kernel.org List-ID: > > Finally, you still haven't explained why the hw needs to be reset in > > ndo_open(). Whatever is causing your lockup can almost certainly be > > triggered in some other way too. I will not accept this side-stepping > > of the issue. > > (I was not aware that you were the final authority on which > patches are accepted upstream.) ./scripts/get_maintainer.pl -f drivers/net/ethernet/aurora/nb8800.c "David S. Miller" (commit_signer:6/6=100%) Mans Rullgard (commit_signer:2/6=33%) Jarod Wilson (commit_signer:1/6=17%,authored:1/6=17%,removed_lines:1/17=6%) Stephen Hemminger (commit_signer:1/6=17%) Florian Fainelli (commit_signer:1/6=17%,added_lines:1/14=7%,removed_lines:11/17=65%) Javier Martinez Canillas (authored:1/6=17%,added_lines:1/14=7%) Johan Hovold (authored:1/6=17%,added_lines:7/14=50%,removed_lines:2/17=12%) Johannes Berg (authored:1/6=17%,added_lines:2/14=14%,removed_lines:2/17=12%) Wei Yongjun (authored:1/6=17%,added_lines:3/14=21%,removed_lines:1/17=6%) David is very likely to listen to Mans's recommendations, since Mans has done most of the review work for this driver. Andrew