From: Kalle Valo <kvalo@codeaurora.org>
To: Robin Murphy <robin.murphy@arm.com>
Cc: imitsyanko@quantenna.com, avinashp@quantenna.com,
smatyukevich@quantenna.com, linux-wireless@vger.kernel.org,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: qtnfmac: Tidy up DMA mask setting
Date: Thu, 3 Aug 2017 10:01:08 +0000 (UTC) [thread overview]
Message-ID: <20170803100110.A8D2D6087E@smtp.codeaurora.org> (raw)
In-Reply-To: <2c3f47792b2e38d5584d641d98e82f8318fefc72.1500917445.git.robin.murphy@arm.com>
Robin Murphy <robin.murphy@arm.com> wrote:
> As the only caller of dma_supported() outside of DMA API internals, the
> qtfnmac driver stands out and invites scrutiny. Thankfully, it's not
> being used for evil, but it is entirely redundant, since it open-codes a
> check that the DMA mask setting functions are going to perform anyway.
> In fact, the whole qtnf_pcie_init_dma_mask() function is nothing more
> than a rather long-winded implementation of dma_set_mask_and_coherent(),
> so let's just use that directly.
>
> Signed-off-by: Robin Murphy <robin.murphy@arm.com>
> Acked-by: Sergey Matyukevich <sergey.matyukevich.os@quantenna.com>
Patch applied to wireless-drivers-next.git, thanks.
13cb8a5845ff qtnfmac: Tidy up DMA mask setting
--
https://patchwork.kernel.org/patch/9859961/
https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
prev parent reply other threads:[~2017-08-03 10:01 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-07-24 17:41 [PATCH] qtfnmac: Tidy up DMA mask setting Robin Murphy
[not found] ` <2c3f47792b2e38d5584d641d98e82f8318fefc72.1500917445.git.robin.murphy-5wv7dgnIgG8@public.gmane.org>
2017-07-25 22:00 ` Sergey Matyukevich
2017-08-03 9:57 ` Kalle Valo
2017-08-03 10:01 ` Kalle Valo [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170803100110.A8D2D6087E@smtp.codeaurora.org \
--to=kvalo@codeaurora.org \
--cc=avinashp@quantenna.com \
--cc=imitsyanko@quantenna.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=robin.murphy@arm.com \
--cc=smatyukevich@quantenna.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).