netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH net] xgene: Always get clk source, but ignore if it's missing for SGMII ports
@ 2017-08-03 13:43 Thomas Bogendoerfer
  2017-08-04 11:00 ` Will Deacon
  2017-08-04 18:30 ` David Miller
  0 siblings, 2 replies; 3+ messages in thread
From: Thomas Bogendoerfer @ 2017-08-03 13:43 UTC (permalink / raw)
  To: isubramanian, kchudgar, qnguyen, netdev, linux-kernel,
	Laura Abbott

From: Thomas Bogendoerfer <tbogendoerfer@suse.de>

Even the driver doesn't do anything with the clk source for SGMII
ports it needs to be enabled by doing a devm_clk_get(), if there is
a clk source in DT.

Fixes: 0db01097cabd ('xgene: Don't fail probe, if there is no clk resource for SGMII interfaces')
Signed-off-by: Thomas Bogendoerfer <tbogendoerfer@suse.de>
Tested-by: Laura Abbott <labbott@redhat.com>
Acked-by: Iyappan Subramanian <isubramanian@apm.com>
---
 drivers/net/ethernet/apm/xgene/xgene_enet_main.c | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/drivers/net/ethernet/apm/xgene/xgene_enet_main.c b/drivers/net/ethernet/apm/xgene/xgene_enet_main.c
index 86058a9f3417..1d307f2def2d 100644
--- a/drivers/net/ethernet/apm/xgene/xgene_enet_main.c
+++ b/drivers/net/ethernet/apm/xgene/xgene_enet_main.c
@@ -1785,9 +1785,9 @@ static int xgene_enet_get_resources(struct xgene_enet_pdata *pdata)
 
 	xgene_enet_gpiod_get(pdata);
 
-	if (pdata->phy_mode != PHY_INTERFACE_MODE_SGMII) {
-		pdata->clk = devm_clk_get(&pdev->dev, NULL);
-		if (IS_ERR(pdata->clk)) {
+	pdata->clk = devm_clk_get(&pdev->dev, NULL);
+	if (IS_ERR(pdata->clk)) {
+		if (pdata->phy_mode != PHY_INTERFACE_MODE_SGMII) {
 			/* Abort if the clock is defined but couldn't be
 			 * retrived. Always abort if the clock is missing on
 			 * DT system as the driver can't cope with this case.
-- 
2.12.3

^ permalink raw reply related	[flat|nested] 3+ messages in thread
end of thread, other threads:[~2017-08-04 18:30 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2017-08-03 13:43 [PATCH net] xgene: Always get clk source, but ignore if it's missing for SGMII ports Thomas Bogendoerfer
2017-08-04 11:00 ` Will Deacon
2017-08-04 18:30 ` David Miller

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).