From: Stephen Hemminger <stephen@networkplumber.org>
To: Florian Lehner <dev@der-flo.net>
Cc: netdev@vger.kernel.org
Subject: Re: [PATCH v5] ss: Enclose IPv6 address in brackets
Date: Fri, 4 Aug 2017 12:05:06 -0700 [thread overview]
Message-ID: <20170804120506.37c6ad60@xeon-e3> (raw)
In-Reply-To: <1aa882d5-b7f6-8b91-b884-0bd45ebeb2a2@der-flo.net>
On Fri, 4 Aug 2017 20:02:52 +0200
Florian Lehner <dev@der-flo.net> wrote:
> diff --git a/misc/ss.c b/misc/ss.c
> index 12763c9..83683b5 100644
> --- a/misc/ss.c
> +++ b/misc/ss.c
> @@ -1046,8 +1046,9 @@ do_numeric:
>
> static void inet_addr_print(const inet_prefix *a, int port, unsigned
> int ifindex)
> {
Your email client is wrapping long lines which leads to malformed patch.
You didn't need buf2, and the code was more complex than it needed to be.
Rather than waiting for yet another version, I just merged in similar
code.
next prev parent reply other threads:[~2017-08-04 19:05 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-07-29 12:29 [PATCH] ss: Enclose IPv6 address in brackets Florian Lehner
2017-07-29 15:26 ` Stephen Hemminger
2017-07-31 10:30 ` Phil Sutter
2017-07-31 16:27 ` Stephen Hemminger
2017-07-31 16:43 ` Phil Sutter
2017-07-31 18:17 ` Florian Lehner
2017-07-31 19:50 ` [PATCH v2] " Florian Lehner
2017-07-31 20:27 ` Phil Sutter
2017-08-01 10:05 ` [PATCH v3] " Florian Lehner
2017-08-01 14:11 ` Phil Sutter
2017-08-01 16:07 ` Florian Lehner
2017-08-01 11:11 ` [PATCH] " David Laight
2017-08-01 14:41 ` Stephen Hemminger
2017-08-01 16:54 ` [PATCH v4] " Florian Lehner
2017-08-03 22:54 ` Stephen Hemminger
2017-08-04 18:02 ` [PATCH v5] " Florian Lehner
2017-08-04 19:05 ` Stephen Hemminger [this message]
2017-08-04 20:46 ` Eric Dumazet
2017-08-04 22:13 ` Stephen Hemminger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170804120506.37c6ad60@xeon-e3 \
--to=stephen@networkplumber.org \
--cc=dev@der-flo.net \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).