From mboxrd@z Thu Jan 1 00:00:00 1970 From: Stephen Hemminger Subject: Re: [PATCH v5] ss: Enclose IPv6 address in brackets Date: Fri, 4 Aug 2017 15:13:26 -0700 Message-ID: <20170804151326.7b035863@xeon-e3> References: <1aa882d5-b7f6-8b91-b884-0bd45ebeb2a2@der-flo.net> <20170804120506.37c6ad60@xeon-e3> <1501879587.25002.49.camel@edumazet-glaptop3.roam.corp.google.com> Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Cc: Florian Lehner , netdev@vger.kernel.org To: Eric Dumazet Return-path: Received: from mail-pg0-f44.google.com ([74.125.83.44]:38121 "EHLO mail-pg0-f44.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752114AbdHDWN3 (ORCPT ); Fri, 4 Aug 2017 18:13:29 -0400 Received: by mail-pg0-f44.google.com with SMTP id l64so12678295pge.5 for ; Fri, 04 Aug 2017 15:13:29 -0700 (PDT) In-Reply-To: <1501879587.25002.49.camel@edumazet-glaptop3.roam.corp.google.com> Sender: netdev-owner@vger.kernel.org List-ID: On Fri, 04 Aug 2017 13:46:27 -0700 Eric Dumazet wrote: > On Fri, 2017-08-04 at 12:05 -0700, Stephen Hemminger wrote: > > On Fri, 4 Aug 2017 20:02:52 +0200 > > Florian Lehner wrote: > > > > > diff --git a/misc/ss.c b/misc/ss.c > > > index 12763c9..83683b5 100644 > > > --- a/misc/ss.c > > > +++ b/misc/ss.c > > > @@ -1046,8 +1046,9 @@ do_numeric: > > > > > > static void inet_addr_print(const inet_prefix *a, int port, unsigned > > > int ifindex) > > > { > > > > Your email client is wrapping long lines which leads to malformed patch. > > > > You didn't need buf2, and the code was more complex than it needed to be. > > > > Rather than waiting for yet another version, I just merged in similar > > code. > > > Also, is this new format accepted for the filter ? > > ss src [::1]:22 It looks like ss would always do that (from earliest git version).