From: Mikko Rapeli <mikko.rapeli@iki.fi>
To: "Dmitry V. Levin" <ldv@altlinux.org>
Cc: netdev@vger.kernel.org, Pavel Emelyanov <xemul@virtuozzo.com>
Subject: Re: uapi: MAX_ADDR_LEN vs. numeric 32
Date: Sat, 5 Aug 2017 01:34:49 +0300 [thread overview]
Message-ID: <20170804223449.GD28459@lakka.kapsi.fi> (raw)
In-Reply-To: <20170804222519.GA11085@altlinux.org>
On Sat, Aug 05, 2017 at 01:25:19AM +0300, Dmitry V. Levin wrote:
>
> On Sat, Aug 05, 2017 at 12:33:25AM +0300, Mikko Rapeli wrote:
> >
> > I find using MAX_ADDR_LEN better than numeric 32, though I doubt this will
> > change any time soon. Would you mind if I change packet_diag.h and
> > if_link.h to use that instead and fix the userspace compilation
> > problems by including netdevice.h?
>
> The alternative fix, that is, to include <linux/netdevice.h>
> which pulls in other headers and a lot of definitions with them,
> has been mentioned in the discussion, too.
> We decided that the fix that was applied would be the least of all evils.
Ok, that's fine then. I'll drop my netdevice.h inclusion patch.
Thanks,
-Mikko
prev parent reply other threads:[~2017-08-04 22:34 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-08-04 21:33 uapi: MAX_ADDR_LEN vs. numeric 32 Mikko Rapeli
2017-08-04 22:25 ` Dmitry V. Levin
2017-08-04 22:34 ` Mikko Rapeli [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170804223449.GD28459@lakka.kapsi.fi \
--to=mikko.rapeli@iki.fi \
--cc=ldv@altlinux.org \
--cc=netdev@vger.kernel.org \
--cc=xemul@virtuozzo.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).